go/go-micro
1
0
Fork 0
mirror of https://github.com/go-micro/go-micro.git synced 2025-07-06 22:35:51 +02:00
Code Issues Releases Activity

1. use default memory registry in grpc plugins (#2317)

Browse Source 
2. try fixing grpc plugin failed to get issue
use v4.0.0-v4.0.0-00010101000000-000000000000 instead of specific version
3. kafka panic on disconnect
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x18 pc=0x1266c50]

goroutine 31 [running]:
github.com/asim/go-micro/plugins/broker/kafka/v3.(*kBroker).Disconnect(0xc0002400c0)
        C:/Workshop/Go/pkg/mod/github.com/asim/go-micro/plugins/broker/kafka/v3@v3.7.0/kafka.go:130 +0xd0
github.com/asim/go-micro/plugins/server/grpc/v3.(*grpcServer).Start.func2()
        C:/Workshop/Go/pkg/mod/github.com/asim/go-micro/plugins/server/grpc/v3@v3.0.0-20210712061837-0532fd9de8ae/grpc.go:998 +0xc8d
created by github.com/asim/go-micro/plugins/server/grpc/v3.(*grpcServer).Start
        C:/Workshop/Go/pkg/mod/github.com/asim/go-micro/plugins/server/grpc/v3@v3.0.0-20210712061837-0532fd9de8ae/grpc.go:917 +0xcaf
exit status 2
This commit is contained in:
Johnson C
2021-10-22 22:30:28 +08:00
committed by GitHub
parent 9edc569e68
commit f96b48dad9
8 changed files with 67 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/broker/kafka/kafka.go
View File

@ -8,8 +8,8 @@ import (
"github.com/Shopify/sarama"
"github.com/google/uuid"
"go-micro.dev/v4/broker"
"go-micro.dev/v4/codec/json"
"go-micro.dev/v4/cmd"
"go-micro.dev/v4/codec/json"
log "go-micro.dev/v4/logger"
)
@ -115,7 +115,7 @@ func (k *kBroker) Connect() error {
k.p = p
k.sc = make([]sarama.Client, 0)
k.connected = true
defer k.scMutex.Unlock()
k.scMutex.Unlock()
return nil
}
@ -127,7 +127,9 @@ func (k *kBroker) Disconnect() error {
client.Close()
}
k.sc = nil
k.p.Close()
if k.p != nil {
k.p.Close()
}
if err := k.c.Close(); err != nil {
return err
}