go/go-notion
1
0
Fork 0
mirror of https://github.com/dstotijn/go-notion.git synced 2025-06-15 00:05:04 +02:00
Code Issues Releases Activity

Add support for Page's Icon retrieval and updates (#21)

Browse Source 
* Add support for Page's Icon retrieval and updates

* Add support for creating a page with an icon

* Fix tests, add icon validation

* Remove unknown icon type `file`

* Add icon support for "create database" endpoint

Co-authored-by: David Stotijn <dstotijn@gmail.com>
This commit is contained in:
Lucas
2021-12-09 17:57:08 +01:00
committed by GitHub
parent 135ef8c421
commit a0926892c2
4 changed files with 189 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

120
client_test.go
View File

@ -943,6 +943,10 @@ func TestCreateDatabase(t *testing.T) {
Title: &notion.EmptyMetadata{},
},
},
Icon: &notion.Icon{
Type: notion.IconTypeEmoji,
Emoji: notion.StringPtr("✌️"),
},
},
respBody: func(_ *http.Request) io.Reader {
return strings.NewReader(
@ -980,6 +984,10 @@ func TestCreateDatabase(t *testing.T) {
"parent": {
"type": "page_id",
"page_id": "b0668f48-8d66-4733-9bdb-2f82215707f7"
},
"icon": {
"type": "emoji",
"emoji": "✌️"
}
}`,
)
@ -1003,6 +1011,10 @@ func TestCreateDatabase(t *testing.T) {
"title": map[string]interface{}{},
},
},
"icon": map[string]interface{}{
"type": "emoji",
"emoji": "✌️",
},
},
expResponse: notion.Database{
ID: "b89664e3-30b4-474a-9cce-c72a4827d1e4",
@ -1031,6 +1043,10 @@ func TestCreateDatabase(t *testing.T) {
Title: &notion.EmptyMetadata{},
},
},
Icon: notion.Icon{
Type: notion.IconTypeEmoji,
Emoji: notion.StringPtr("✌️"),
},
},
expError: nil,
},
@ -1808,6 +1824,106 @@ func TestUpdatePageProps(t *testing.T) {
},
expError: nil,
},
{
name: "page icon, successful response",
params: notion.UpdatePageParams{
Icon: &notion.Icon{
Type: notion.IconTypeExternal,
External: &notion.IconExternal{
URL: "https://www.notion.so/front-static/pages/pricing/pro.png",
},
},
},
respBody: func(_ *http.Request) io.Reader {
return strings.NewReader(
`{
"object": "page",
"id": "cb261dc5-6c85-4767-8585-3852382fb466",
"created_time": "2021-05-14T09:15:46.796Z",
"last_edited_time": "2021-05-22T15:54:31.116Z",
"parent": {
"type": "page_id",
"page_id": "b0668f48-8d66-4733-9bdb-2f82215707f7"
},
"icon": {
"type": "external",
"external": {
"url": "https://www.notion.so/front-static/pages/pricing/pro.png"
}
},
"archived": false,
"url": "https://www.notion.so/Avocado-251d2b5f268c4de2afe9c71ff92ca95c",
"properties": {
"title": {
"id": "title",
"type": "title",
"title": [
{
"type": "text",
"text": {
"content": "Lorem ipsum",
"link": null
},
"annotations": {
"bold": false,
"italic": false,
"strikethrough": false,
"underline": false,
"code": false,
"color": "default"
},
"plain_text": "Lorem ipsum",
"href": null
}
]
}
}
}`,
)
},
respStatusCode: http.StatusOK,
expPostBody: map[string]interface{}{
"icon": map[string]interface{}{
"type": "external",
"external": map[string]interface{}{
"url": "https://www.notion.so/front-static/pages/pricing/pro.png",
},
},
},
expResponse: notion.Page{
ID: "cb261dc5-6c85-4767-8585-3852382fb466",
CreatedTime: mustParseTime(time.RFC3339Nano, "2021-05-14T09:15:46.796Z"),
LastEditedTime: mustParseTime(time.RFC3339Nano, "2021-05-22T15:54:31.116Z"),
URL: "https://www.notion.so/Avocado-251d2b5f268c4de2afe9c71ff92ca95c",
Parent: notion.Parent{
Type: notion.ParentTypePage,
PageID: "b0668f48-8d66-4733-9bdb-2f82215707f7",
},
Icon: &notion.Icon{
Type: notion.IconTypeExternal,
External: &notion.IconExternal{
URL: "https://www.notion.so/front-static/pages/pricing/pro.png",
},
},
Properties: notion.PageProperties{
Title: notion.PageTitle{
Title: []notion.RichText{
{
Type: notion.RichTextTypeText,
Text: &notion.Text{
Content: "Lorem ipsum",
},
Annotations: &notion.Annotations{
Color: notion.ColorDefault,
},
PlainText: "Lorem ipsum",
},
},
},
},
},
expError: nil,
},
{
name: "database page props, successful response",
params: notion.UpdatePageParams{
@ -1943,10 +2059,10 @@ func TestUpdatePageProps(t *testing.T) {
expError: errors.New("notion: failed to update page properties: foobar (code: validation_error, status: 400)"),
},
{
name: "missing page title and database properties",
name: "missing any params",
params: notion.UpdatePageParams{},
expResponse: notion.Page{},
expError: errors.New("notion: invalid page params: either database page properties or title is required"),
expError: errors.New("notion: invalid page params: at least one of database page properties, title or icon is required"),
},
}