support cloudfront for static files

tools/devops/README.md

@@ -11,6 +11,7 @@
         "acm:ListCertificates",
         "acm:RequestCertificate",
         "acm:DescribeCertificate",
+        "cloudfront:CreateDistribution",
         "ec2:DescribeSubnets",
         "ec2:DescribeSecurityGroups",
         "ec2:CreateSecurityGroup",

tools/devops/cmd/cicd/s3_batch_upload.go

@@ -13,7 +13,7 @@ import (
 
 // DirectoryIterator represents an iterator of a specified directory
 type DirectoryIterator struct {
-	dir string
+	dir       string
 	filePaths []string
 	bucket    string
 	keyPrefix string
@@ -37,7 +37,7 @@ func NewDirectoryIterator(bucket, keyPrefix, dir, acl string) s3manager.BatchUpl
 	})
 
 	return &DirectoryIterator{
-		dir: dir,
+		dir:       dir,
 		filePaths: paths,
 		bucket:    bucket,
 		keyPrefix: keyPrefix,
@@ -81,12 +81,12 @@ func (di *DirectoryIterator) UploadObject() s3manager.BatchUploadObject {
 	buffer := make([]byte, size)
 	f.Read(buffer)
 
-	nextPath, _ := filepath.Rel(di.dir,  di.next.path)
+	nextPath, _ := filepath.Rel(di.dir, di.next.path)
 
 	return s3manager.BatchUploadObject{
 		Object: &s3manager.UploadInput{
 			Bucket:      aws.String(di.bucket),
-			Key:         aws.String(filepath.Join(di.keyPrefix,nextPath)),
+			Key:         aws.String(filepath.Join(di.keyPrefix, nextPath)),
 			Body:        bytes.NewReader(buffer),
 			ContentType: aws.String(http.DetectContentType(buffer)),
 			ACL:         acl,

tools/devops/cmd/cicd/service_deploy.go

@@ -17,13 +17,13 @@ import (
 	"strings"
 	"time"
 
-	"github.com/aws/aws-sdk-go/service/cloudfront"
 	"geeks-accelerator/oss/saas-starter-kit/internal/platform/tests"
 	"geeks-accelerator/oss/saas-starter-kit/internal/schema"
 	"geeks-accelerator/oss/saas-starter-kit/tools/devops/internal/retry"
 	"github.com/aws/aws-sdk-go/aws"
 	"github.com/aws/aws-sdk-go/aws/awserr"
 	"github.com/aws/aws-sdk-go/service/acm"
+	"github.com/aws/aws-sdk-go/service/cloudfront"
 	"github.com/aws/aws-sdk-go/service/cloudwatchlogs"
 	"github.com/aws/aws-sdk-go/service/ec2"
 	"github.com/aws/aws-sdk-go/service/ecr"
@@ -282,53 +282,76 @@ func NewServiceDeployRequest(log *log.Logger, flags ServiceDeployFlags) (*servic
 						},
 					})
 
-					if flags.S3BucketPublicCloudfront {
+				// The S3 key prefix used as the origin when cloud front is enabled.
+				if req.S3BucketPublicKeyPrefix == "" {
+					req.S3BucketPublicKeyPrefix = "/public"
+				}
 
-					allowedMethods:= &cloudfront.AllowedMethods{}
+				if flags.S3BucketPublicCloudfront {
-					allowedMethods.SetItems(aws.StringSlice([]string{ "HEAD", "GET"}))
+					allowedMethods := &cloudfront.AllowedMethods{
+						Items: aws.StringSlice([]string{"HEAD", "GET"}),
+					}
+					allowedMethods.Quantity = aws.Int64(int64(len(allowedMethods.Items)))
 
-					cacheMethods := &cloudfront.CachedMethods{}
+					cacheMethods := &cloudfront.CachedMethods{
-					cacheMethods.SetItems(aws.StringSlice([]string{ "HEAD", "GET"}))
+						Items: aws.StringSlice([]string{"HEAD", "GET"}),
+					}
+					cacheMethods.Quantity = aws.Int64(int64(len(cacheMethods.Items)))
 					allowedMethods.SetCachedMethods(cacheMethods)
 
-					domainId := "S3"+req.S3BucketPublicName
+					domainId := "S3-" + req.S3BucketPublicName
 					domainName := fmt.Sprintf("%s.s3.%s.amazonaws.com", req.S3BucketPublicName, req.AwsCreds.Region)
 
-					origins := &cloudfront.Origins{}
+					origins := &cloudfront.Origins{
-					origins.SetItems([]*cloudfront.Origin{
+						Items: []*cloudfront.Origin{
-						&cloudfront.Origin{
+							&cloudfront.Origin{
-							Id: aws.String(domainId),
+								Id:         aws.String(domainId),
-							DomainName: aws.String(domainName),
+								DomainName: aws.String(domainName),
-							OriginPath: aws.String(req.S3BucketPublicKeyPrefix),
+								OriginPath: aws.String(req.S3BucketPublicKeyPrefix),
+								S3OriginConfig: &cloudfront.S3OriginConfig{
+									OriginAccessIdentity: aws.String(""),
+								},
+								CustomHeaders: &cloudfront.CustomHeaders{
+									Quantity: aws.Int64(0),
+								},
+							},
 						},
-					})
+					}
+					origins.Quantity = aws.Int64(int64(len(origins.Items)))
 
 					req.CloudfrontPublic = &cloudfront.DistributionConfig{
-						Comment: aws.String(""),
+						Comment:       aws.String(""),
-						Enabled: aws.Bool(true),
+						Enabled:       aws.Bool(true),
-						HttpVersion: aws.String( "http2"),
+						HttpVersion:   aws.String("http2"),
 						IsIPV6Enabled: aws.Bool(true),
 						DefaultCacheBehavior: &cloudfront.DefaultCacheBehavior{
 							TargetOriginId: aws.String(domainId),
 							AllowedMethods: allowedMethods,
-							Compress: aws.Bool(true),
+							Compress:       aws.Bool(true),
-							DefaultTTL: aws.Int64(1209600),
+							DefaultTTL:     aws.Int64(1209600),
-							MinTTL: aws.Int64(604800),
+							MinTTL:         aws.Int64(604800),
-							MaxTTL: aws.Int64(31536000),
+							MaxTTL:         aws.Int64(31536000),
 							ForwardedValues: &cloudfront.ForwardedValues{
-								QueryString: 	aws.Bool(true),
+								QueryString: aws.Bool(true),
+								Cookies: &cloudfront.CookiePreference{
+									Forward: aws.String("none"),
+								},
 							},
+							TrustedSigners: &cloudfront.TrustedSigners{
+								Enabled:  aws.Bool(false),
+								Quantity: aws.Int64(0),
+							},
+							ViewerProtocolPolicy: aws.String("allow-all"),
 						},
 						Origins: origins,
 						ViewerCertificate: &cloudfront.ViewerCertificate{
-							CertificateSource: aws.String("cloudfront"),
+							CertificateSource:            aws.String("cloudfront"),
-							MinimumProtocolVersion: aws.String("TLSv1"),
+							MinimumProtocolVersion:       aws.String("TLSv1"),
 							CloudFrontDefaultCertificate: aws.Bool(true),
 						},
-						PriceClass: aws.String("PriceClass_All"),
+						PriceClass:      aws.String("PriceClass_All"),
 						CallerReference: aws.String("devops-deploy"),
 					}
-					req.CloudfrontPublic = nil
 				}
 			}
 
@@ -404,11 +427,6 @@ func NewServiceDeployRequest(log *log.Logger, flags ServiceDeployFlags) (*servic
 					})
 			}
 
-			// The S3 key prefix used as the origin when cloud front is enabled.
-			if req.S3BucketPublicKeyPrefix == "" {
-				req.S3BucketPublicKeyPrefix = "public"
-			}
-
 			// The S3 prefix used to upload static files served to public.
 			if req.StaticFilesS3Prefix == "" {
 				req.StaticFilesS3Prefix = filepath.Join(req.S3BucketPublicKeyPrefix, releaseTag(req.Env, req.ServiceName), "static")
@@ -1075,7 +1093,7 @@ func ServiceDeploy(log *log.Logger, req *serviceDeployRequest) error {
 
 		_, err := svc.CreateDistribution(&cloudfront.CreateDistributionInput{
 			DistributionConfig: req.CloudfrontPublic,
-		} )
+		})
 		if err != nil {
 			if aerr, ok := err.(awserr.Error); !ok || (aerr.Code() != cloudfront.ErrCodeDistributionAlreadyExists) {
 				return errors.Wrapf(err, "Failed to create cloudfront distribution '%s'", *req.CloudfrontPublic.DefaultCacheBehavior.TargetOriginId)
@@ -2406,7 +2424,7 @@ func ServiceDeploy(log *log.Logger, req *serviceDeployRequest) error {
 			"{HOST_NAMES}":   strings.Join(req.ServiceHostNames, ","),
 
 			"{STATIC_FILES_S3_ENABLED}":         "false",
-			"{STATIC_FILES_S3_PREFIX}":          "",
+			"{STATIC_FILES_S3_PREFIX}":          req.StaticFilesS3Prefix,
 			"{STATIC_FILES_CLOUDFRONT_ENABLED}": "false",
 			"{STATIC_FILES_IMG_RESIZE_ENABLED}": "false",