go/gops
go/gops
1
0
Fork 0
mirror of https://github.com/google/gops.git synced 2024-11-19 20:31:58 +02:00
Code Issues Releases Activity

cmd/shared: add 'off' option to setgc (#201)

Browse Source 
To stop GC completely, debug.SetGCPercentage needs to receive a negative
integer. Passing a negative integer is cumbersome:
$ gops setgc <pid> -- -1

This commit adds a more user-friendly way to achieve that:
$ gops setgc <pid> off

This behavior is aligned with that of the GOGC env variable, where
negative or "off" can be set to stop the GC.
This commit is contained in:
segevda 2023-02-10 12:24:10 +02:00 committed by GitHub
parent 2b6817995c
commit dbeb29cd3e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
README.md
View File

@ -189,6 +189,11 @@ The following command sets it to 10%:
``` sh ``` sh
$ gops setgc (<pid>|<addr>) 10 $ gops setgc (<pid>|<addr>) 10
``` ```
The following command turns off the garbage collector:
```sh
$ gops setgc (<pid>|<addr>) off
```
#### $ gops version (\<pid\>|\<addr\>) #### $ gops version (\<pid\>|\<addr\>)

16
internal/cmd/shared.go
View File

@ -43,7 +43,7 @@ func AgentCommands() []*cobra.Command {
}, },
{ {
name: "setgc", name: "setgc",
short: "Sets the garbage collection target percentage.", short: "Sets the garbage collection target percentage. To completely stop GC, set to 'off'",
fn: setGC, fn: setGC,
}, },
{ {
@ -127,9 +127,17 @@ func setGC(addr net.TCPAddr, params []string) error {
if len(params) != 1 { if len(params) != 1 {
return errors.New("missing gc percentage") return errors.New("missing gc percentage")
} }
perc, err := strconv.ParseInt(params[0], 10, strconv.IntSize) var (
if err != nil { perc int64
return err err error
)
if strings.ToLower(params[0]) == "off" {
perc = -1
} else {
perc, err = strconv.ParseInt(params[0], 10, strconv.IntSize)
if err != nil {
return err
}
} }
buf := make([]byte, binary.MaxVarintLen64) buf := make([]byte, binary.MaxVarintLen64)
binary.PutVarint(buf, perc) binary.PutVarint(buf, perc)