go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-07-05 00:59:04 +02:00
Code Issues Releases Activity

fix: Silent failure caused by branching logic

Browse Source 
Changed the branching after the `GetContents` call to *first* check for
a non-404 error (internal failure of some sort) and then proceed to
check the status to determine whether to `CreateFile` or `UpdateFile`.
This commit is contained in:
Southclaws
2018-02-10 13:14:52 +00:00
committed by Carlos Alexandro Becker
parent f8a7ac602e
commit 0a37305745
1 changed files with 14 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
internal/client/github.go
View File

@ -63,7 +63,11 @@ func (c *githubClient) CreateFile(
path,
&github.RepositoryContentGetOptions{},
)
if err != nil && res.StatusCode == 404 {
if err != nil && res.StatusCode != 404 {
return
}
if res.StatusCode == 404 {
_, _, err = c.client.Repositories.CreateFile(
ctx,
repo.Owner,
@ -71,16 +75,16 @@ func (c *githubClient) CreateFile(
path,
options,
)
return
} else {
options.SHA = file.SHA
_, _, err = c.client.Repositories.UpdateFile(
ctx,
repo.Owner,
repo.Name,
path,
options,
)
}
options.SHA = file.SHA
_, _, err = c.client.Repositories.UpdateFile(
ctx,
repo.Owner,
repo.Name,
path,
options,
)
return
}