From 143b955f1bde0236f68f943dee12f6e7d0fe61d6 Mon Sep 17 00:00:00 2001 From: Carlos Alexandro Becker Date: Sat, 6 Nov 2021 15:33:18 -0300 Subject: [PATCH] refactor: improve release defaults (#2627) --- internal/pipe/release/release.go | 47 +++++++++++++------------------- 1 file changed, 19 insertions(+), 28 deletions(-) diff --git a/internal/pipe/release/release.go b/internal/pipe/release/release.go index d915c007e..661cbec7d 100644 --- a/internal/pipe/release/release.go +++ b/internal/pipe/release/release.go @@ -22,7 +22,7 @@ var ErrMultipleReleases = errors.New("multiple releases are defined. Only one is // Pipe for github release. type Pipe struct{} -func (Pipe) String() string { return "github/gitlab/gitea releases" } +func (Pipe) String() string { return "scm releases" } func (Pipe) Skip(ctx *context.Context) bool { return ctx.Config.Release.Disable } // Default sets the pipe defaults. @@ -45,41 +45,32 @@ func (Pipe) Default(ctx *context.Context) error { ctx.Config.Release.NameTemplate = "{{.Tag}}" } - // nolint: exhaustive switch ctx.TokenType { case context.TokenTypeGitLab: - { - if ctx.Config.Release.GitLab.Name == "" { - repo, err := git.ExtractRepoFromConfig() - if err != nil { - return err - } - ctx.Config.Release.GitLab = repo + if ctx.Config.Release.GitLab.Name == "" { + repo, err := git.ExtractRepoFromConfig() + if err != nil { + return err } - - return nil + ctx.Config.Release.GitLab = repo } case context.TokenTypeGitea: - { - if ctx.Config.Release.Gitea.Name == "" { - repo, err := git.ExtractRepoFromConfig() - if err != nil { - return err - } - ctx.Config.Release.Gitea = repo + if ctx.Config.Release.Gitea.Name == "" { + repo, err := git.ExtractRepoFromConfig() + if err != nil { + return err } - - return nil + ctx.Config.Release.Gitea = repo } - } - - // We keep github as default for now - if ctx.Config.Release.GitHub.Name == "" { - repo, err := git.ExtractRepoFromConfig() - if err != nil && !ctx.Snapshot { - return err + default: + // We keep github as default for now + if ctx.Config.Release.GitHub.Name == "" { + repo, err := git.ExtractRepoFromConfig() + if err != nil && !ctx.Snapshot { + return err + } + ctx.Config.Release.GitHub = repo } - ctx.Config.Release.GitHub = repo } // Check if we have to check the git tag for an indicator to mark as pre release