go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-11-06 09:09:29 +02:00
Code Issues Releases Activity

fix: revert defaulting build.id to build.binary

Browse Source 
refs #3098
refs #3063

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
This commit is contained in:
Carlos A Becker
2022-05-11 11:41:33 -03:00
parent a5ef8e3cc2
commit 17e4d62791
2 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
internal/pipe/build/build.go
View File

@@ -73,7 +73,7 @@ func buildWithDefaults(ctx *context.Context, build config.Build) (config.Build,
build.Binary = ctx.Config.ProjectName
}
if build.ID == "" {
build.ID = build.Binary
build.ID = ctx.Config.ProjectName
}
for k, v := range build.Env {
build.Env[k] = os.ExpandEnv(v)

5
internal/pipe/build/build_test.go
View File

@@ -288,7 +288,6 @@ func TestDefaultBuildID(t *testing.T) {
Builds: []config.Build{
{
Binary: "{{.Env.FOO}}",
ID: "bar",
},
{
Binary: "bar",
@@ -296,11 +295,11 @@ func TestDefaultBuildID(t *testing.T) {
},
},
}
require.EqualError(t, Pipe{}.Default(ctx), "found 2 builds with the ID 'bar', please fix your config")
require.EqualError(t, Pipe{}.Default(ctx), "found 2 builds with the ID 'foo', please fix your config")
build1 := ctx.Config.Builds[0].ID
build2 := ctx.Config.Builds[1].ID
require.Equal(t, build1, build2)
require.Equal(t, "bar", build2)
require.Equal(t, "foo", build2)
}
func TestSeveralBuildsWithTheSameID(t *testing.T) {