go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-03-17 20:47:50 +02:00
Code Issues Releases Activity

fix: nfpm replacements deprecation (#3793)

Browse Source 
closes  #3792

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
This commit is contained in:
Carlos Alexandro Becker 2023-02-21 21:54:18 -03:00 committed by GitHub
parent 2c80588251
commit 1858bace7e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 41 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
internal/pipe/nfpm/nfpm.go
View File

@ -62,6 +62,11 @@ func (Pipe) Default(ctx *context.Context) error {
if len(fpm.Replacements) != 0 {
deprecate.Notice(ctx, "nfpms.replacements")
}
for _, rfpm := range fpm.Overrides {
if len(rfpm.Replacements) != 0 {
deprecate.Notice(ctx, "nfpms.replacements")
}
}
ids.Inc(fpm.ID)
}

36
internal/pipe/nfpm/nfpm_test.go
View File

@ -36,6 +36,42 @@ func TestRunPipeNoFormats(t *testing.T) {
testlib.AssertSkipped(t, Pipe{}.Run(ctx))
}
func TestDefaultsDeprecated(t *testing.T) {
t.Run("replacements", func(t *testing.T) {
ctx := context.New(config.Project{
NFPMs: []config.NFPM{
{
NFPMOverridables: config.NFPMOverridables{
Replacements: map[string]string{
"linux": "Tux",
},
},
},
},
})
require.NoError(t, Pipe{}.Default(ctx))
require.True(t, ctx.Deprecated)
})
t.Run("replacements overrides", func(t *testing.T) {
ctx := context.New(config.Project{
NFPMs: []config.NFPM{
{
Overrides: map[string]config.NFPMOverridables{
"apk": {
Replacements: map[string]string{
"linux": "Tux",
},
},
},
},
},
})
require.NoError(t, Pipe{}.Default(ctx))
require.True(t, ctx.Deprecated)
})
}
func TestRunPipeError(t *testing.T) {
ctx := context.New(config.Project{
Dist: t.TempDir(),