go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-07-05 00:59:04 +02:00
Code Issues Releases Activity

refactor(http): remove redundant nil check (#4563)

Browse Source 
From the Go specification [^1]:

> "3. If the map is nil, the number of iterations is 0."

Therefore, it is not required to do a nil check for the map before the
loop.

[^1]: https://go.dev/ref/spec#For_range

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
This commit is contained in:
Eng Zer Jun
2024-01-22 08:51:03 +08:00
committed by GitHub
parent 6097ea50f5
commit 1d44832f6b
1 changed files with 6 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
internal/http/http.go
View File

@ -238,15 +238,13 @@ func uploadAsset(ctx *context.Context, upload *config.Upload, artifact *artifact
} }
log.Debugf("generated target url: %s", targetURL) log.Debugf("generated target url: %s", targetURL)
headers := map[string]string{} headers := make(map[string]string, len(upload.CustomHeaders))
if upload.CustomHeaders != nil { for name, value := range upload.CustomHeaders {
for name, value := range upload.CustomHeaders { resolvedValue, err := tmpl.New(ctx).WithArtifact(artifact).Apply(value)
resolvedValue, err := tmpl.New(ctx).WithArtifact(artifact).Apply(value) if err != nil {
if err != nil { return fmt.Errorf("%s: %s: failed to resolve custom_headers template: %w", upload.Name, kind, err)
return fmt.Errorf("%s: %s: failed to resolve custom_headers template: %w", upload.Name, kind, err)
}
headers[name] = resolvedValue
} }
headers[name] = resolvedValue
} }
if upload.ChecksumHeader != "" { if upload.ChecksumHeader != "" {
sum, err := artifact.Checksum("sha256") sum, err := artifact.Checksum("sha256")