go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-03-17 20:47:50 +02:00
Code Issues Releases Activity

fix(release): publish tag with skip_upload (#4745)

Browse Source 
Closes #4743
Refs #4626
This commit is contained in:
Carlos Alexandro Becker 2024-04-03 13:55:54 -03:00 committed by GitHub
parent 0ff94f13e4
commit 22b7daadb4
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 27 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/pipe/release/release.go
View File

@ -131,6 +131,9 @@ func doPublish(ctx *context.Context, client client.Client) error {
return err
}
if skipUpload {
if err := client.PublishRelease(ctx, releaseID); err != nil {
return err
}
return pipe.Skip("release.skip_upload is set")
}

27
internal/pipe/release/release_test.go
View File

@ -665,9 +665,15 @@ func TestSkip(t *testing.T) {
SkipUpload: "{{ .Env.FOO }}",
},
})
ctx.Artifacts.Add(&artifact.Artifact{
Name: "a",
Path: "./doc.go",
Type: artifact.UploadableFile,
})
client := &client.Mock{}
testlib.AssertSkipped(t, doPublish(ctx, client))
require.True(t, client.CreatedRelease)
require.True(t, client.ReleasePublished)
require.False(t, client.UploadedFile)
})
@ -677,15 +683,30 @@ func TestSkip(t *testing.T) {
SkipUpload: "true",
},
})
ctx.Artifacts.Add(&artifact.Artifact{
Name: "a",
Path: "./doc.go",
Type: artifact.UploadableFile,
})
client := &client.Mock{}
testlib.AssertSkipped(t, doPublish(ctx, client))
require.True(t, client.CreatedRelease)
require.True(t, client.ReleasePublished)
require.False(t, client.UploadedFile)
})
t.Run("dont skip", func(t *testing.T) {
b, err := Pipe{}.Skip(testctx.New())
require.NoError(t, err)
require.False(t, b)
ctx := testctx.New()
ctx.Artifacts.Add(&artifact.Artifact{
Name: "a",
Path: "./doc.go",
Type: artifact.UploadableFile,
})
client := &client.Mock{}
require.NoError(t, doPublish(ctx, client))
require.True(t, client.CreatedRelease)
require.True(t, client.ReleasePublished)
require.True(t, client.UploadedFile)
})
}