go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-02-05 13:15:26 +02:00
Code Issues Releases Activity

test: remove redundant require.Error (#5253)

Browse Source 
The PR refactors tests by removing redundant `require.Error` statements
that are followed by `require.ErrorContains`. `require.ErrorContains`
will fail if `err` is `nil`, so `require.Error` is not needed.
This commit is contained in:
Oleksandr Redko 2024-11-07 03:16:31 +02:00 committed by GitHub
parent 9f042fa273
commit 2b76fb266f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/pipe/slack/slack_test.go
View File

@ -120,7 +120,6 @@ func TestParseRichText(t *testing.T) {
require.NoError(t, yaml.Unmarshal(badBlocksSlackConf(), &project))
ctx := testctx.NewWithCfg(project, testctx.WithVersion(testVersion))
_, _, err := parseAdvancedFormatting(ctx)
require.Error(t, err)
require.ErrorContains(t, err, "json")
})
@ -130,7 +129,6 @@ func TestParseRichText(t *testing.T) {
require.NoError(t, yaml.Unmarshal(badAttachmentsSlackConf(), &project))
ctx := testctx.NewWithCfg(project, testctx.WithVersion(testVersion))
_, _, err := parseAdvancedFormatting(ctx)
require.Error(t, err)
require.ErrorContains(t, err, "json")
})
}
@ -151,7 +149,6 @@ func TestRichText(t *testing.T) {
require.NoError(t, yaml.Unmarshal(badBlocksSlackConf(), &project))
ctx := testctx.NewWithCfg(project, testctx.WithVersion(testVersion))
err := Pipe{}.Announce(ctx)
require.Error(t, err)
require.ErrorContains(t, err, "json")
})
}

2
pkg/config/config_slack_test.go
View File

@ -125,7 +125,6 @@ func TestUnmarshalYAMLSlackBlocks(t *testing.T) {
var block SlackBlock
err := block.UnmarshalYAML(erf)
require.Error(t, err)
require.ErrorContains(t, err, testError)
})
@ -134,7 +133,6 @@ func TestUnmarshalYAMLSlackBlocks(t *testing.T) {
var attachment SlackAttachment
err := attachment.UnmarshalYAML(erf)
require.Error(t, err)
require.ErrorContains(t, err, testError)
})
}