go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2024-12-31 01:53:50 +02:00
Code Issues Releases Activity

fix(snap): do not fail with "NEEDS REVIEW" message

Browse Source 
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
This commit is contained in:
Carlos A Becker 2021-05-26 14:39:11 +00:00
parent 046c60d20d
commit 3843761902
No known key found for this signature in database
GPG Key ID: E61E2F7DC14AB940
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/pipe/snapcraft/snapcraft.go
View File

@ -333,6 +333,7 @@ func create(ctx *context.Context, snap config.Snapcraft, arch string, binaries [
const (
reviewWaitMsg = `Waiting for previous upload(s) to complete their review process.`
humanReviewMsg = `A human will soon review your snap`
needsReviewMsg = `(NEEDS REVIEW)`
)
func push(ctx *context.Context, snap *artifact.Artifact) error {
@ -342,7 +343,7 @@ func push(ctx *context.Context, snap *artifact.Artifact) error {
/* #nosec */
cmd := exec.CommandContext(ctx, "snapcraft", "upload", "--release=stable", snap.Path)
if out, err := cmd.CombinedOutput(); err != nil {
if strings.Contains(string(out), reviewWaitMsg) || strings.Contains(string(out), humanReviewMsg) {
if strings.Contains(string(out), reviewWaitMsg) || strings.Contains(string(out), humanReviewMsg) || strings.Contains(string(out), needsReviewMsg) {
log.Warn(reviewWaitMsg)
} else {
return fmt.Errorf("failed to push %s package: %s", snap.Path, string(out))