From 3d48782917525924ab287c3a5de0cd61d80637fd Mon Sep 17 00:00:00 2001
From: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Date: Sat, 15 Aug 2020 17:16:48 -0300
Subject: [PATCH] fix: brew name template (#1756)

Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
---
 internal/pipe/brew/brew.go                    |  6 ++
 internal/pipe/brew/brew_test.go               | 64 +++++++++++++++++++
 .../pipe/brew/testdata/foo_is_bar.rb.golden   | 16 +++++
 3 files changed, 86 insertions(+)
 create mode 100644 internal/pipe/brew/testdata/foo_is_bar.rb.golden

diff --git a/internal/pipe/brew/brew.go b/internal/pipe/brew/brew.go
index 99d75bbff..f9f8dc428 100644
--- a/internal/pipe/brew/brew.go
+++ b/internal/pipe/brew/brew.go
@@ -175,6 +175,12 @@ func doRun(ctx *context.Context, brew config.Homebrew, cl client.Client) error {
 		return ErrNoArchivesFound
 	}
 
+	name, err := tmpl.New(ctx).Apply(brew.Name)
+	if err != nil {
+		return err
+	}
+	brew.Name = name
+
 	content, err := buildFormula(ctx, brew, cl, archives)
 	if err != nil {
 		return err
diff --git a/internal/pipe/brew/brew_test.go b/internal/pipe/brew/brew_test.go
index ceff19fc3..9911f84c3 100644
--- a/internal/pipe/brew/brew_test.go
+++ b/internal/pipe/brew/brew_test.go
@@ -232,6 +232,70 @@ func TestRunPipe(t *testing.T) {
 		})
 	}
 }
+
+func TestRunPipeNameTemplate(t *testing.T) {
+	folder, err := ioutil.TempDir("", "goreleasertest")
+	assert.NoError(t, err)
+	var ctx = &context.Context{
+		Git: context.GitInfo{
+			CurrentTag: "v1.0.1",
+		},
+		Version:   "1.0.1",
+		Artifacts: artifact.New(),
+		Env: map[string]string{
+			"FOO_BAR": "is_bar",
+		},
+		Config: config.Project{
+			Dist:        folder,
+			ProjectName: "foo",
+			Brews: []config.Homebrew{
+				{
+					Name: "foo_{{ .Env.FOO_BAR }}",
+					Tap: config.RepoRef{
+						Owner: "foo",
+						Name:  "bar",
+					},
+					IDs: []string{
+						"foo",
+					},
+				},
+			},
+		},
+	}
+	var path = filepath.Join(folder, "bin.tar.gz")
+	ctx.Artifacts.Add(&artifact.Artifact{
+		Name:   "bin.tar.gz",
+		Path:   path,
+		Goos:   "darwin",
+		Goarch: "amd64",
+		Type:   artifact.UploadableArchive,
+		Extra: map[string]interface{}{
+			"ID":                 "foo",
+			"Format":             "tar.gz",
+			"ArtifactUploadHash": "820ead5d9d2266c728dce6d4d55b6460",
+		},
+	})
+
+	_, err = os.Create(path)
+	assert.NoError(t, err)
+	client := &DummyClient{}
+	var distFile = filepath.Join(folder, "foo_is_bar.rb")
+
+	assert.NoError(t, doRun(ctx, ctx.Config.Brews[0], client))
+	assert.True(t, client.CreatedFile)
+	var golden = "testdata/foo_is_bar.rb.golden"
+	if *update {
+		assert.NoError(t, ioutil.WriteFile(golden, []byte(client.Content), 0655))
+	}
+	bts, err := ioutil.ReadFile(golden)
+	assert.NoError(t, err)
+	assert.Equal(t, string(bts), client.Content)
+
+	distBts, err := ioutil.ReadFile(distFile)
+	assert.NoError(t, err)
+	assert.Equal(t, string(bts), string(distBts))
+}
+
 func TestRunPipeForMultipleArmVersions(t *testing.T) {
 	for name, fn := range map[string]func(ctx *context.Context){
 		"multiple_armv5": func(ctx *context.Context) {
diff --git a/internal/pipe/brew/testdata/foo_is_bar.rb.golden b/internal/pipe/brew/testdata/foo_is_bar.rb.golden
new file mode 100644
index 000000000..c15e1ed5a
--- /dev/null
+++ b/internal/pipe/brew/testdata/foo_is_bar.rb.golden
@@ -0,0 +1,16 @@
+# This file was generated by GoReleaser. DO NOT EDIT.
+class FooIsBar < Formula
+  desc ""
+  homepage ""
+  version "1.0.1"
+  bottle :unneeded
+
+  if OS.mac?
+    url "https://dummyhost/download/v1.0.1/bin.tar.gz"
+    sha256 "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
+  elsif OS.linux?
+  end
+
+  def install
+  end
+end