mirror of
https://github.com/goreleaser/goreleaser.git
synced 2025-03-17 20:47:50 +02:00
fix: reject docker.files as . or inside dist (#1175)
* fix: reject docker.files as . or inside dist Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com> * fix: deprecated method Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
This commit is contained in:
parent
792b883f59
commit
423308443c
@ -40,6 +40,11 @@ func (Pipe) Default(ctx *context.Context) error {
|
||||
if docker.Goarch == "" {
|
||||
docker.Goarch = "amd64"
|
||||
}
|
||||
for _, f := range docker.Files {
|
||||
if f == "." || strings.HasPrefix(f, ctx.Config.Dist) {
|
||||
return fmt.Errorf("invalid docker.files: can't be . or inside dist folder: %s", f)
|
||||
}
|
||||
}
|
||||
}
|
||||
// only set defaults if there is exactly 1 docker setup in the config file.
|
||||
if len(ctx.Config.Dockers) != 1 {
|
||||
|
@ -732,6 +732,34 @@ func TestDefaultNoDockers(t *testing.T) {
|
||||
assert.Empty(t, ctx.Config.Dockers)
|
||||
}
|
||||
|
||||
func TestDefaultFilesDot(t *testing.T) {
|
||||
var ctx = &context.Context{
|
||||
Config: config.Project{
|
||||
Dist: "/tmp/distt",
|
||||
Dockers: []config.Docker{
|
||||
{
|
||||
Files: []string{"./lala", "./lolsob", "."},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
assert.EqualError(t, Pipe{}.Default(ctx), `invalid docker.files: can't be . or inside dist folder: .`)
|
||||
}
|
||||
|
||||
func TestDefaultFilesDis(t *testing.T) {
|
||||
var ctx = &context.Context{
|
||||
Config: config.Project{
|
||||
Dist: "/tmp/dist",
|
||||
Dockers: []config.Docker{
|
||||
{
|
||||
Files: []string{"./fooo", "/tmp/dist/asdasd/asd", "./bar"},
|
||||
},
|
||||
},
|
||||
},
|
||||
}
|
||||
assert.EqualError(t, Pipe{}.Default(ctx), `invalid docker.files: can't be . or inside dist folder: /tmp/dist/asdasd/asd`)
|
||||
}
|
||||
|
||||
func TestDefaultSet(t *testing.T) {
|
||||
var ctx = &context.Context{
|
||||
Config: config.Project{
|
||||
|
Loading…
x
Reference in New Issue
Block a user