From 4ba8843d6a068b24c5d0e6f47649f3ccfe34c990 Mon Sep 17 00:00:00 2001 From: Carlos Alexandro Becker Date: Fri, 30 Dec 2016 09:59:24 -0200 Subject: [PATCH] errgroup on compress pipe --- pipeline/compress/zip.go | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/pipeline/compress/zip.go b/pipeline/compress/zip.go index 64595a6fe..f10a67ef8 100644 --- a/pipeline/compress/zip.go +++ b/pipeline/compress/zip.go @@ -9,6 +9,7 @@ import ( "github.com/goreleaser/releaser/config" "github.com/goreleaser/releaser/uname" + "golang.org/x/sync/errgroup" ) type Pipe struct{} @@ -18,15 +19,15 @@ func (Pipe) Name() string { } func (Pipe) Work(config config.ProjectConfig) error { - // TODO use a errgroup here? + var g errgroup.Group for _, system := range config.Build.Oses { for _, arch := range config.Build.Arches { - if err := create(system, arch, config); err != nil { - return err - } + g.Go(func() error { + return create(system, arch, config) + }) } } - return nil + return g.Wait() } func create(system, arch string, config config.ProjectConfig) error {