go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-10-30 23:58:09 +02:00
Code Issues Releases Activity

refactor: allow builders to have custom defaults

Browse Source
This commit is contained in:
Carlos Alexandro Becker
2018-01-21 23:37:39 -02:00
parent 42a8f0b194
commit 4e6982a524
5 changed files with 28 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
build/build.go
View File

@@ -31,6 +31,7 @@ type Options struct {
}
type Builder interface {
Default(build config.Build) config.Build
Build(ctx *context.Context, build config.Build, options Options) error
}

22
internal/builders/golang/build.go
View File

@@ -27,6 +27,28 @@ func init() {
type Builder struct {
}
func (*Builder) Default(build config.Build) config.Build {
if build.Main == "" {
build.Main = "."
}
if len(build.Goos) == 0 {
build.Goos = []string{"linux", "darwin"}
}
if len(build.Goarch) == 0 {
build.Goarch = []string{"amd64", "386"}
}
if len(build.Goarm) == 0 {
build.Goarm = []string{"6"}
}
if build.Ldflags == "" {
build.Ldflags = "-s -w -X main.version={{.Version}} -X main.commit={{.Commit}} -X main.date={{.Date}}"
}
if build.Lang == "go" && len(build.Targets) == 0 {
build.Targets = matrix(build)
}
return build
}
func (*Builder) Build(ctx *context.Context, cfg config.Build, options build.Options) error {
if err := checkMain(ctx, cfg); err != nil {
return err

5
internal/builders/golang/buildmatrix/targets.go → internal/builders/golang/targets.go
View File

@@ -1,4 +1,4 @@
package buildmatrix
package golang
import (
"fmt"
@@ -18,8 +18,7 @@ func (t target) String() string {
return fmt.Sprintf("%s_%s", t.os, t.arch)
}
// All returns all valid build targets for a given build
func All(build config.Build) (result []string) {
func matrix(build config.Build) (result []string) {
var targets []target
for _, target := range allBuildTargets(build) {
if !valid(target) {

4
internal/builders/golang/buildmatrix/targets_test.go → internal/builders/golang/targets_test.go
View File

@@ -1,4 +1,4 @@
package buildmatrix
package golang
import (
"fmt"
@@ -52,7 +52,7 @@ func TestAllBuildTargets(t *testing.T) {
"freebsd_arm_7",
"openbsd_386",
"openbsd_amd64",
}, All(build))
}, matrix(build))
}
func TestGoosGoarchCombos(t *testing.T) {

21
pipeline/build/build.go
View File

@@ -15,7 +15,6 @@ import (
// langs to init
_ "github.com/goreleaser/goreleaser/internal/builders/golang"
"github.com/goreleaser/goreleaser/internal/builders/golang/buildmatrix"
)
// Pipe for build
@@ -56,25 +55,7 @@ func buildWithDefaults(ctx *context.Context, build config.Build) config.Build {
if build.Binary == "" {
build.Binary = ctx.Config.Release.GitHub.Name
}
if build.Main == "" {
build.Main = "."
}
if len(build.Goos) == 0 {
build.Goos = []string{"linux", "darwin"}
}
if len(build.Goarch) == 0 {
build.Goarch = []string{"amd64", "386"}
}
if len(build.Goarm) == 0 {
build.Goarm = []string{"6"}
}
if build.Ldflags == "" {
build.Ldflags = "-s -w -X main.version={{.Version}} -X main.commit={{.Commit}} -X main.date={{.Date}}"
}
if build.Lang == "go" && len(build.Targets) == 0 {
build.Targets = buildmatrix.All(build)
}
return build
return builders.For(build.Lang).Default(build)
}
func runPipeOnBuild(ctx *context.Context, build config.Build) error {