go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-07-05 00:59:04 +02:00
Code Issues Releases Activity

fix: log request-id on upload error and release create/update (#3608)

Browse Source 
this should help when reporting issues to github, especially the magical
"failed successfully" error

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
This commit is contained in:
Carlos Alexandro Becker
2022-11-29 21:38:39 -03:00
committed by GitHub
parent 24d86475b4
commit 50bd78439c
1 changed files with 24 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
internal/client/github.go
View File

@ -252,12 +252,19 @@ func (c *githubClient) createOrUpdateRelease(ctx *context.Context, data *github.
data.GetTagName(),
)
if err != nil {
release, _, err = c.client.Repositories.CreateRelease(
release, resp, err := c.client.Repositories.CreateRelease(
ctx,
ctx.Config.Release.GitHub.Owner,
ctx.Config.Release.GitHub.Name,
data,
)
if err == nil {
log.WithFields(log.Fields{
"name": data.GetName(),
"release-id": release.GetID(),
"request-id": resp.Header.Get("X-GitHub-Request-Id"),
}).Info("release created")
}
return release, err
}
@ -266,14 +273,21 @@ func (c *githubClient) createOrUpdateRelease(ctx *context.Context, data *github.
}
func (c *githubClient) updateRelease(ctx *context.Context, id int64, data *github.RepositoryRelease) (*github.RepositoryRelease, error) {
repo, _, err := c.client.Repositories.EditRelease(
release, resp, err := c.client.Repositories.EditRelease(
ctx,
ctx.Config.Release.GitHub.Owner,
ctx.Config.Release.GitHub.Name,
id,
data,
)
return repo, err
if err == nil {
log.WithFields(log.Fields{
"name": data.GetName(),
"release-id": release.GetID(),
"request-id": resp.Header.Get("X-GitHub-Request-Id"),
}).Info("release updated")
}
return release, err
}
func (c *githubClient) ReleaseURLTemplate(ctx *context.Context) (string, error) {
@ -310,6 +324,13 @@ func (c *githubClient) Upload(
},
file,
)
if err != nil {
log.WithFields(log.Fields{
"name": artifact.Name,
"release-id": releaseID,
"request-id": resp.Header.Get("X-GitHub-Request-Id"),
}).Warn("upload failed")
}
if err == nil {
return nil
}