From 57a69dbe47f255bcb8e8eac2a9e8c626fd8a3d78 Mon Sep 17 00:00:00 2001 From: Dinar Valeev Date: Fri, 19 Mar 2021 14:24:50 +0100 Subject: [PATCH] fix: docker manifest on draft release (#2119) docker manifests exepcted to be pushed on draft. - add test for such case Signed-off-by: Dinar Valeev --- internal/pipe/docker/docker.go | 3 --- internal/pipe/docker/docker_test.go | 12 ++++++++++++ 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/internal/pipe/docker/docker.go b/internal/pipe/docker/docker.go index 63ae105d8..15dcd98e9 100644 --- a/internal/pipe/docker/docker.go +++ b/internal/pipe/docker/docker.go @@ -155,9 +155,6 @@ func process(ctx *context.Context, docker config.Docker, artifacts []*artifact.A if ctx.SkipPublish { return pipe.ErrSkipPublishEnabled } - if ctx.Config.Release.Draft { - return pipe.Skip("release is marked as draft") - } if strings.TrimSpace(docker.SkipPush) == "auto" && ctx.Semver.Prerelease != "" { return pipe.Skip("prerelease detected with 'auto' push, skipping docker publish") } diff --git a/internal/pipe/docker/docker_test.go b/internal/pipe/docker/docker_test.go index 479f2a06c..c2b852836 100644 --- a/internal/pipe/docker/docker_test.go +++ b/internal/pipe/docker/docker_test.go @@ -1002,6 +1002,18 @@ func TestDefaultDockerfile(t *testing.T) { require.Equal(t, "Dockerfile", ctx.Config.Dockers[1].Dockerfile) } +func TestDraftRelease(t *testing.T) { + var ctx = &context.Context{ + Config: config.Project{ + Release: config.Release{ + Draft: true, + }, + }, + } + + require.False(t, pipe.IsSkip(Pipe{}.Publish(ctx))) +} + func TestDefaultNoDockers(t *testing.T) { var ctx = &context.Context{ Config: config.Project{