go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-03-17 20:47:50 +02:00
Code Issues Releases Activity

refactor: Simplify docker test

Browse Source 
Remove unnecessary fields in `TestRunPipe` test cases
This commit is contained in:
Albert Salim 2018-10-20 20:36:11 +08:00 committed by Carlos Alexandro Becker
parent 64ce2d5bd6
commit 5af006f415
1 changed files with 81 additions and 140 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

91
internal/pipe/docker/docker_test.go
View File

@ -160,7 +160,6 @@ func TestRunPipe(t *testing.T) {
Binary: "mybin",
TagTemplates: []string{
"{{.Tag}}-{{.Env.FOO}}",
"v{{.Major}}.{{.Minor}}",
},
BuildFlagTemplates: []string{
"--label=org.label-schema.version={{.Version}}",
@ -169,7 +168,6 @@ func TestRunPipe(t *testing.T) {
},
expect: []string{
registry + "goreleaser/test_run_pipe:v1.0.0-123",
registry + "goreleaser/test_run_pipe:v1.0",
},
assertImageLabels: shouldFindImagesWithLabels(
"goreleaser/test_run_pipe",
@ -186,12 +184,8 @@ func TestRunPipe(t *testing.T) {
Goarch: "amd64",
Dockerfile: "testdata/Dockerfile",
Binary: "mybin",
TagTemplates: []string{
"latest",
},
Files: []string{
"testdata/extra_file.txt",
},
TagTemplates: []string{"latest"},
Files: []string{"testdata/extra_file.txt"},
},
{
Image: registry + "goreleaser/multiplefiles2",
@ -199,12 +193,8 @@ func TestRunPipe(t *testing.T) {
Goarch: "amd64",
Dockerfile: "testdata/Dockerfile",
Binary: "mybin",
TagTemplates: []string{
"latest",
},
Files: []string{
"testdata/extra_file.txt",
},
TagTemplates: []string{"latest"},
Files: []string{"testdata/extra_file.txt"},
},
},
expect: []string{
@ -251,21 +241,10 @@ func TestRunPipe(t *testing.T) {
Dockerfile: "testdata/Dockerfile",
Binary: "mybin",
SkipPush: true,
TagTemplates: []string{
"{{.Tag}}-{{.Env.FOO}}",
"v{{.Major}}",
"v{{.Major}}.{{.Minor}}",
"latest",
},
Files: []string{
"testdata/extra_file.txt",
},
TagTemplates: []string{"latest"},
},
},
expect: []string{
registry + "goreleaser/test_run_pipe:v1.0.0-123",
registry + "goreleaser/test_run_pipe:v1",
registry + "goreleaser/test_run_pipe:v1.0",
registry + "goreleaser/test_run_pipe:latest",
},
assertImageLabels: noLabels,
@ -280,12 +259,7 @@ func TestRunPipe(t *testing.T) {
Goarch: "amd64",
Dockerfile: "testdata/Dockerfile",
Binary: "mybin",
TagTemplates: []string{
"{{.Version}}",
},
Files: []string{
"testdata/extra_file.txt",
},
TagTemplates: []string{"{{.Version}}"},
},
},
expect: []string{
@ -303,17 +277,10 @@ func TestRunPipe(t *testing.T) {
Goarch: "amd64",
Dockerfile: "testdata/Dockerfile",
Binary: "mybin",
TagTemplates: []string{
"{{.Tag}}-{{.Env.FOO}}",
"latest",
},
Files: []string{
"testdata/extra_file.txt",
},
TagTemplates: []string{"latest"},
},
},
expect: []string{
registry + "goreleaser/test_run_pipe:v1.0.0-123",
registry + "goreleaser/test_run_pipe:latest",
},
assertImageLabels: noLabels,
@ -328,9 +295,7 @@ func TestRunPipe(t *testing.T) {
Goarch: "amd64",
Dockerfile: "testdata/Dockerfile",
Binary: "mybin",
TagTemplates: []string{
"latest",
},
TagTemplates: []string{"latest"},
BuildFlagTemplates: []string{
"--label=foo=bar",
},
@ -351,9 +316,7 @@ func TestRunPipe(t *testing.T) {
Goarch: "amd64",
Dockerfile: "testdata/Dockerfile",
Binary: "mybin",
TagTemplates: []string{
"latest",
},
TagTemplates: []string{"latest"},
BuildFlagTemplates: []string{
"--bad-flag",
},
@ -371,9 +334,7 @@ func TestRunPipe(t *testing.T) {
Goarch: "amd64",
Dockerfile: "testdata/Dockerfile.bad",
Binary: "mybin",
TagTemplates: []string{
"{{.Version}}",
},
TagTemplates: []string{"latest"},
},
},
assertImageLabels: noLabels,
@ -405,9 +366,7 @@ func TestRunPipe(t *testing.T) {
Goarch: "amd64",
Dockerfile: "testdata/Dockerfile",
Binary: "mybin",
TagTemplates: []string{
"latest",
},
TagTemplates: []string{"latest"},
BuildFlagTemplates: []string{
"--label=tag={{.Tag}",
},
@ -442,9 +401,7 @@ func TestRunPipe(t *testing.T) {
Goarch: "amd64",
Dockerfile: "testdata/Dockerfile",
Binary: "mybin",
TagTemplates: []string{
"latest",
},
TagTemplates: []string{"latest"},
BuildFlagTemplates: []string{
"--label=nope={{.Env.NOPE}}",
},
@ -465,19 +422,12 @@ func TestRunPipe(t *testing.T) {
SkipPush: true,
TagTemplates: []string{
"{{.Tag}}-{{.Env.FOO}}",
"v{{.Major}}",
"v{{.Major}}.{{.Minor}}",
"latest",
},
Files: []string{
"testdata/extra_file.txt",
},
},
},
expect: []string{
registry + "goreleaser/mybin:v1.0.0-123",
registry + "goreleaser/mybin:v1",
registry + "goreleaser/mybin:v1.0",
registry + "goreleaser/mybin:latest",
},
assertImageLabels: noLabels,
@ -492,15 +442,11 @@ func TestRunPipe(t *testing.T) {
Goarch: "amd64",
Binary: "mybin",
Dockerfile: "testdata/Dockerfile",
TagTemplates: []string{
"{{.Tag}}",
"latest",
},
TagTemplates: []string{"latest"},
},
},
expect: []string{
"docker.io/nope:latest",
"docker.io/nope:v1.0.0",
},
assertImageLabels: noLabels,
assertError: shouldErr(`requested access to the resource is denied`),
@ -514,9 +460,7 @@ func TestRunPipe(t *testing.T) {
Goarch: "amd64",
Binary: "mybin",
Dockerfile: "testdata/Dockerfilezzz",
TagTemplates: []string{
"{{.Tag}}",
},
TagTemplates: []string{"latest"},
},
},
assertImageLabels: noLabels,
@ -530,13 +474,11 @@ func TestRunPipe(t *testing.T) {
Goos: "linux",
Goarch: "amd64",
Binary: "mybin",
Dockerfile: "testdata/Dockerfile",
TagTemplates: []string{"latest"},
Files: []string{
"testdata/nope.txt",
},
Dockerfile: "testdata/Dockerfile",
TagTemplates: []string{
"{{.Tag}}",
},
},
},
assertImageLabels: noLabels,
@ -717,7 +659,6 @@ func TestDefault(t *testing.T) {
assert.Equal(t, ctx.Config.Builds[0].Binary, docker.Binary)
assert.Equal(t, "Dockerfile", docker.Dockerfile)
assert.Equal(t, []string{":{{ .Version }}"}, docker.ImageTemplates)
}
func TestDefaultNoDockers(t *testing.T) {