go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-03-19 20:57:53 +02:00
Code Issues Releases Activity

fix: make --release-notes flags more deterministic (#2888)

Browse Source 
* fix: make --release-notes flags more deterministic

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>

* chore: fmt

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
This commit is contained in:
Carlos Alexandro Becker 2022-02-06 22:09:46 -03:00 committed by GitHub
parent 3426d04837
commit 5f30f3606a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/pipe/changelog/changelog.go
View File

@ -49,7 +49,7 @@ func (Pipe) Run(ctx *context.Context) error {
} }
ctx.ReleaseNotes = notes ctx.ReleaseNotes = notes
if ctx.ReleaseNotes != "" { if ctx.ReleaseNotesFile != "" || ctx.ReleaseNotesTmpl != "" {
return nil return nil
} }

16
internal/pipe/changelog/changelog_test.go
View File

@ -25,13 +25,27 @@ func TestChangelogProvidedViaFlag(t *testing.T) {
require.Equal(t, "c0ff33 coffeee\n", ctx.ReleaseNotes) require.Equal(t, "c0ff33 coffeee\n", ctx.ReleaseNotes)
} }
func TestChangelogProvidedViaFlagIsAnWhitespaceOnlyFile(t *testing.T) { func TestChangelogProvidedViaFlagIsAWhitespaceOnlyFile(t *testing.T) {
ctx := context.New(config.Project{}) ctx := context.New(config.Project{})
ctx.ReleaseNotesFile = "testdata/changes-empty.md" ctx.ReleaseNotesFile = "testdata/changes-empty.md"
require.NoError(t, Pipe{}.Run(ctx)) require.NoError(t, Pipe{}.Run(ctx))
require.Equal(t, "\n", ctx.ReleaseNotes) require.Equal(t, "\n", ctx.ReleaseNotes)
} }
func TestChangelogProvidedViaFlagIsReallyEmpty(t *testing.T) {
ctx := context.New(config.Project{})
ctx.ReleaseNotesFile = "testdata/changes-really-empty.md"
require.NoError(t, Pipe{}.Run(ctx))
require.Equal(t, "", ctx.ReleaseNotes)
}
func TestChangelogTmplProvidedViaFlagIsReallyEmpty(t *testing.T) {
ctx := context.New(config.Project{})
ctx.ReleaseNotesTmpl = "testdata/changes-really-empty.md"
require.NoError(t, Pipe{}.Run(ctx))
require.Equal(t, "", ctx.ReleaseNotes)
}
func TestTemplatedChangelogProvidedViaFlag(t *testing.T) { func TestTemplatedChangelogProvidedViaFlag(t *testing.T) {
ctx := context.New(config.Project{}) ctx := context.New(config.Project{})
ctx.ReleaseNotesFile = "testdata/changes.md" ctx.ReleaseNotesFile = "testdata/changes.md"

0
internal/pipe/changelog/testdata/changes-really-empty.md vendored Normal file
View File