diff --git a/checksum/checksum.go b/checksum/checksum.go index 18cfdc9af..3a2fd1046 100644 --- a/checksum/checksum.go +++ b/checksum/checksum.go @@ -1,7 +1,6 @@ package checksum import ( - "crypto/md5" "crypto/sha256" "encoding/hex" "hash" @@ -9,11 +8,6 @@ import ( "os" ) -// MD5 sum of the given file -func MD5(path string) (result string, err error) { - return calculate(md5.New(), path) -} - // SHA256 sum of the given file func SHA256(path string) (result string, err error) { return calculate(sha256.New(), path) diff --git a/checksum/checksum_test.go b/checksum/checksum_test.go index 86e273dc4..71fe9d68d 100644 --- a/checksum/checksum_test.go +++ b/checksum/checksum_test.go @@ -22,11 +22,6 @@ func TestChecksums(t *testing.T) { _, err = file.WriteString("lorem ipsum") assert.NoError(err) assert.NoError(file.Close()) - t.Run("md5", func(t *testing.T) { - sum, err := MD5(file.Name()) - assert.NoError(err) - assert.Equal("80a751fde577028640c419000e33eba6", sum) - }) t.Run("sha256", func(t *testing.T) { sum, err := SHA256(file.Name()) assert.NoError(err) @@ -36,7 +31,7 @@ func TestChecksums(t *testing.T) { func TestOpenFailure(t *testing.T) { var assert = assert.New(t) - sum, err := MD5("/tmp/this-file-wont-exist-I-hope") + sum, err := SHA256("/tmp/this-file-wont-exist-I-hope") assert.Empty(sum) assert.Error(err) } diff --git a/pipeline/checksums/checksums.go b/pipeline/checksums/checksums.go index 8b6e486e8..ea78b5442 100644 --- a/pipeline/checksums/checksums.go +++ b/pipeline/checksums/checksums.go @@ -39,10 +39,6 @@ func checksums(ctx *context.Context, name string) error { if err != nil { return err } - md5, err := checksum.MD5(artifact) - if err != nil { - return err - } file, err := os.OpenFile( filepath.Join(ctx.Config.Dist, checksums), os.O_APPEND|os.O_WRONLY|os.O_CREATE|os.O_TRUNC, @@ -52,11 +48,7 @@ func checksums(ctx *context.Context, name string) error { return err } defer func() { _ = file.Close() }() - var template = "%v %v\n" - if _, err = file.WriteString(fmt.Sprintf(template, "md5sum", md5)); err != nil { - return err - } - if _, err = file.WriteString(fmt.Sprintf(template, "sha256sum", sha)); err != nil { + if _, err = file.WriteString(fmt.Sprintf("%v\t%v\n", sha, name)); err != nil { return err } ctx.AddArtifact(file.Name()) diff --git a/pipeline/checksums/checksums_test.go b/pipeline/checksums/checksums_test.go index ee23f901d..70db2f604 100644 --- a/pipeline/checksums/checksums_test.go +++ b/pipeline/checksums/checksums_test.go @@ -38,6 +38,5 @@ func TestPipe(t *testing.T) { assert.Contains(ctx.Artifacts, "binary.checksums", "binary") bts, err := ioutil.ReadFile(filepath.Join(folder, "binary.checksums")) assert.NoError(err) - assert.Contains(string(bts), "md5sum 5ac749fbeec93607fc28d666be85e73a") - assert.Contains(string(bts), "sha256sum 61d034473102d7dac305902770471fd50f4c5b26f6831a56dd90b5184b3c30fc") + assert.Contains(string(bts), "61d034473102d7dac305902770471fd50f4c5b26f6831a56dd90b5184b3c30fc binary") }