From 6fb427e5c8c3bd47e9901d5ca74ddd83f10320d0 Mon Sep 17 00:00:00 2001 From: Carlos Alexandro Becker Date: Fri, 28 Dec 2018 18:58:11 -0200 Subject: [PATCH] Revert "fix: retry upload (#900)" This reverts commit 6e09a19a83ed4b643981800aa2ecf1143dcb23c9. --- internal/client/github.go | 20 +------------------- internal/pipe/put/put.go | 1 + 2 files changed, 2 insertions(+), 19 deletions(-) diff --git a/internal/client/github.go b/internal/client/github.go index 835aa84c5..93052b3b2 100644 --- a/internal/client/github.go +++ b/internal/client/github.go @@ -133,18 +133,6 @@ func (c *githubClient) Upload( releaseID int64, name string, file *os.File, -) error { - return c.uploadRetry(ctx, releaseID, name, file, 0) -} - -const maxRetries = 10 - -func (c *githubClient) uploadRetry( - ctx *context.Context, - releaseID int64, - name string, - file *os.File, - retry int, ) error { _, _, err := c.client.Repositories.UploadReleaseAsset( ctx, @@ -156,11 +144,5 @@ func (c *githubClient) uploadRetry( }, file, ) - if err != nil { - if retry > maxRetries { - return err - } - return err - } - return c.uploadRetry(ctx, releaseID, name, file, retry+1) + return err } diff --git a/internal/pipe/put/put.go b/internal/pipe/put/put.go index 3a0d8ddf6..11f8683cf 100644 --- a/internal/pipe/put/put.go +++ b/internal/pipe/put/put.go @@ -46,3 +46,4 @@ func (Pipe) Publish(ctx *context.Context) error { }) } +