go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-01-04 03:11:55 +02:00
Code Issues Releases Activity

fix: do not skip scoop on draft releases (#3889)

Browse Source 
all other pipes don't, not sure why scoop was doing it.

closes #3887
This commit is contained in:
Carlos Alexandro Becker 2023-03-24 00:02:15 -03:00 committed by GitHub
parent 44f8fae305
commit 723484d157
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 0 additions and 37 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
internal/pipe/scoop/scoop.go
View File

@ -139,9 +139,6 @@ func doPublish(ctx *context.Context, cl client.Client) error {
if strings.TrimSpace(scoop.SkipUpload) == "auto" && ctx.Semver.Prerelease != "" {
return pipe.Skip("release is prerelease")
}
if ctx.Config.Release.Draft {
return pipe.Skip("release is marked as draft")
}
relDisabled, err := tmpl.New(ctx).Bool(ctx.Config.Release.Disable)
if err != nil {

34
internal/pipe/scoop/scoop_test.go
View File

@ -299,40 +299,6 @@ func Test_doRun(t *testing.T) {
shouldNotErr,
noAssertions,
},
{
"is draft",
args{
func() *context.Context {
return testctx.NewWithCfg(
config.Project{
ProjectName: "run-pipe",
Release: config.Release{
Draft: true,
},
Scoop: config.Scoop{
Bucket: config.RepoRef{
Owner: "test",
Name: "test",
},
Description: "A run pipe test formula",
Homepage: "https://github.com/goreleaser",
},
},
testctx.GitHubTokenType,
testctx.WithCurrentTag("v1.0.1"),
testctx.WithVersion("1.0.1"),
)
},
client.NewMock(),
},
[]artifact.Artifact{
{Name: "foo_1.0.1_windows_amd64.tar.gz", Goos: "windows", Goarch: "amd64", Goamd64: "v1", Path: file},
{Name: "foo_1.0.1_windows_386.tar.gz", Goos: "windows", Goarch: "386", Path: file},
},
shouldNotErr,
shouldErr("release is marked as draft"),
noAssertions,
},
{
"is prerelease and skip upload set to auto",
args{