fix: lint issues

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>

internal/pipe/changelog/changelog_test.go

@@ -672,7 +672,7 @@ func TestGetChangeloger(t *testing.T) {
 		ctx.TokenType = context.TokenTypeGitea
 		c, err := getChangeloger(ctx)
 		require.NoError(t, err)
-		require.IsType(t, c, &scmChangeloger{})
+		require.IsType(t, &scmChangeloger{}, c)
 	})
 
 	t.Run("invalid", func(t *testing.T) {

internal/pipe/gomod/gomod_proxy.go

@@ -160,7 +160,7 @@ func proxyBuild(ctx *context.Context, build *config.Build) error {
 	log.Debugf("tidying")
 	cmd := exec.CommandContext(ctx, ctx.Config.GoMod.GoBinary, "get", ctx.ModulePath+"@"+ctx.Git.CurrentTag)
 	cmd.Dir = dir
-	cmd.Env = append(ctx.Config.GoMod.Env, os.Environ()...)
+	cmd.Env = append(ctx.Config.GoMod.Env, os.Environ()...) //nolint: gocritic
 	if out, err := cmd.CombinedOutput(); err != nil {
 		return newDetailedErrProxy(err, string(out))
 	}

internal/pipe/nfpm/nfpm.go

@@ -458,7 +458,7 @@ func create(ctx *context.Context, fpm config.NFPM, format string, artifacts []*a
 	}
 
 	if !strings.HasSuffix(packageFilename, ext) {
-		packageFilename = packageFilename + ext
+		packageFilename += ext
 	}
 
 	path := filepath.Join(ctx.Config.Dist, packageFilename)

internal/pipe/sbom/sbom_test.go

@@ -560,7 +560,7 @@ func testSBOMCataloging(
 		}),
 	)
 
-	wantFiles := append(artifacts, sbomPaths...)
+	wantFiles := append(artifacts, sbomPaths...) //nolint: gocritic
 	sort.Strings(wantFiles)
 	require.ElementsMatch(tb, wantFiles, gotFiles, "SBOM paths differ")
 

internal/pipe/sign/sign_test.go

@@ -705,7 +705,7 @@ func testSign(
 		}),
 	)
 
-	wantFiles := append(artifacts, signaturePaths...)
+	wantFiles := append(artifacts, signaturePaths...) //nolint: gocritic
 	sort.Strings(wantFiles)
 	require.ElementsMatch(tb, wantFiles, gotFiles)
 

internal/pipe/upx/upx_test.go

@@ -173,10 +173,6 @@ func TestFindBinaries(t *testing.T) {
 			goarm := ""
 			gomips := ""
 			goamd64 := ""
-			switch goos {
-			case "windows":
-				ext = ".exe"
-			}
 			if goos == "windows" {
 				ext = ".exe"
 			}

pkg/config/config_test.go

@@ -4,7 +4,6 @@ import (
 	"bytes"
 	"fmt"
 	"os"
-	"path/filepath"
 	"strings"
 	"testing"
 
@@ -50,7 +49,7 @@ func TestFile(t *testing.T) {
 	f, err := os.CreateTemp(t.TempDir(), "config")
 	require.NoError(t, err)
 	require.NoError(t, f.Close())
-	_, err = Load(filepath.Join(f.Name()))
+	_, err = Load(f.Name())
 	require.NoError(t, err)
 }