go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-02-15 13:53:25 +02:00
Code Issues Releases Activity

feat: validate changelog config for invalid fields

Browse Source 
If the user configures the changelog section with an invalid key, show
an error.
This commit is contained in:
Carlos Alexandro Becker 2017-10-20 15:59:33 -02:00 committed by Carlos Alexandro Becker
parent 3d6e6cbcf6
commit 76087d53cd
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
config/config.go
View File

@ -196,12 +196,18 @@ type Docker struct {
// Filters config // Filters config
type Filters struct { type Filters struct {
Exclude []string `yaml:",omitempty"` Exclude []string `yaml:",omitempty"`
// Capture all undefined fields and should be empty after loading
XXX map[string]interface{} `yaml:",inline"`
} }
// Changelog Config // Changelog Config
type Changelog struct { type Changelog struct {
Filters Filters `yaml:",omitempty"` Filters Filters `yaml:",omitempty"`
Sort string `yaml:",omitempty"` Sort string `yaml:",omitempty"`
// Capture all undefined fields and should be empty after loading
XXX map[string]interface{} `yaml:",inline"`
} }
// Project includes all project configuration // Project includes all project configuration
@ -284,6 +290,8 @@ func checkOverflows(config Project) error {
for i, docker := range config.Dockers { for i, docker := range config.Dockers {
overflow.check(docker.XXX, fmt.Sprintf("docker[%d]", i)) overflow.check(docker.XXX, fmt.Sprintf("docker[%d]", i))
} }
overflow.check(config.Changelog.XXX, "changelog")
overflow.check(config.Changelog.Filters.XXX, "changelog.filters")
return overflow.err() return overflow.err()
} }

2
config/config_test.go
View File

@ -59,7 +59,7 @@ func TestFileNotFound(t *testing.T) {
func TestInvalidFields(t *testing.T) { func TestInvalidFields(t *testing.T) {
_, err := Load("testdata/invalid_config.yml") _, err := Load("testdata/invalid_config.yml")
assert.EqualError(t, err, "unknown fields in the config file: invalid_root, archive.invalid_archive, archive.format_overrides[0].invalid_archive_fmtoverrides, brew.invalid_brew, brew.github.invalid_brew_github, builds[0].invalid_builds, builds[0].hooks.invalid_builds_hooks, builds[0].ignored_builds[0].invalid_builds_ignore, fpm.invalid_fpm, release.invalid_release, release.github.invalid_release_github, build.invalid_build, builds.hooks.invalid_build_hook, builds.ignored_builds[0].invalid_build_ignore, snapshot.invalid_snapshot, docker[0].invalid_docker") assert.EqualError(t, err, "unknown fields in the config file: invalid_root, archive.invalid_archive, archive.format_overrides[0].invalid_archive_fmtoverrides, brew.invalid_brew, brew.github.invalid_brew_github, builds[0].invalid_builds, builds[0].hooks.invalid_builds_hooks, builds[0].ignored_builds[0].invalid_builds_ignore, fpm.invalid_fpm, release.invalid_release, release.github.invalid_release_github, build.invalid_build, builds.hooks.invalid_build_hook, builds.ignored_builds[0].invalid_build_ignore, snapshot.invalid_snapshot, docker[0].invalid_docker, changelog.invalid_changelog, changelog.filters.invalid_filters")
} }
func TestInvalidYaml(t *testing.T) { func TestInvalidYaml(t *testing.T) {

4
config/testdata/invalid_config.yml vendored
View File

@ -29,3 +29,7 @@ snapshot:
invalid_snapshot: 1 invalid_snapshot: 1
dockers: dockers:
- invalid_docker: 1 - invalid_docker: 1
changelog:
invalid_changelog: 1
filters:
invalid_filters: 1