feat: release with target_commitish in another repo

We should not imply the target_commitish, as some users might want to
have the code in one repo and the releases in another (e.g. private
code, public releases), so the commit might not be there.

We should instead allow the user to set the `target_commitish` (or not),
and pass it down to the github api.

refs 95bba02211
refs #3044
refs #3330

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

internal/client/github.go

@@ -217,17 +217,27 @@ func (c *githubClient) CreateRelease(ctx *context.Context, body string) (string,
 	body = truncateReleaseBody(body)
 
 	data := &github.RepositoryRelease{
-		Name:            github.String(title),
-		TagName:         github.String(ctx.Git.CurrentTag),
-		TargetCommitish: github.String(ctx.Git.Commit),
-		Body:            github.String(body),
-		Draft:           github.Bool(ctx.Config.Release.Draft),
-		Prerelease:      github.Bool(ctx.PreRelease),
+		Name:       github.String(title),
+		TagName:    github.String(ctx.Git.CurrentTag),
+		Body:       github.String(body),
+		Draft:      github.Bool(ctx.Config.Release.Draft),
+		Prerelease: github.Bool(ctx.PreRelease),
 	}
+
 	if ctx.Config.Release.DiscussionCategoryName != "" {
 		data.DiscussionCategoryName = github.String(ctx.Config.Release.DiscussionCategoryName)
 	}
 
+	if target := ctx.Config.Release.TargetCommitish; target != "" {
+		target, err := tmpl.New(ctx).Apply(target)
+		if err != nil {
+			return "", err
+		}
+		if target != "" {
+			data.TargetCommitish = github.String(target)
+		}
+	}
+
 	release, _, err = c.client.Repositories.GetReleaseByTag(
 		ctx,
 		ctx.Config.Release.GitHub.Owner,