go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-03-17 20:47:50 +02:00
Code Issues Releases Activity

fix: Fix Brew formula class name when using custom name

Browse Source 
The #597 added support for customizing the final Brew formula name.
The generated *.rb file still were using the project name as
class name and installing with custom name didn't work.
Fixed the issue by using the `name` field as an input for
building the class name, which defaults to project name
if no name given.
This commit is contained in:
Erno Aapa 2018-03-25 13:31:24 +03:00 committed by Carlos Alexandro Becker
parent 07b021ca11
commit 79a48eae7b
2 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
pipeline/brew/brew.go
View File

@ -165,7 +165,7 @@ func dataFor(ctx *context.Context, client client.Client, artifact artifact.Artif
}
var cfg = ctx.Config.Brew
return templateData{
Name: formulaNameFor(ctx.Config.ProjectName),
Name: formulaNameFor(ctx.Config.Brew.Name),
DownloadURL: ctx.Config.GitHubURLs.Download,
Desc: cfg.Description,
Homepage: cfg.Homepage,

7
pipeline/brew/brew_test.go
View File

@ -203,8 +203,13 @@ func TestRunPipe(t *testing.T) {
assert.NoError(tt, doRun(ctx, client))
assert.True(tt, client.CreatedFile)
_, err := os.Stat(filepath.Join(folder, "custom-brew-name.rb"))
distFile := filepath.Join(folder, "custom-brew-name.rb")
_, err := os.Stat(distFile)
assert.NoError(t, err)
distBts, err := ioutil.ReadFile(distFile)
assert.NoError(tt, err)
assert.Contains(tt, string(distBts), "class CustomBrewName < Formula")
})
}