feat: allow to always log signing output (#2731)

* feat: allow to always log signing output

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>

* fix: improve code a bit

Signed-off-by: Carlos A Becker <caarlos0@gmail.com>

internal/logext/writer.go

@@ -22,7 +22,12 @@ const (
 
 // NewWriter creates a new log writer.
 func NewWriter(fields log.Fields, out Output) io.Writer {
-	if isDebug() {
+	return NewConditionalWriter(fields, out, false)
+}
+
+// NewConditionalWriter creates a new log writer that only writes when the given condition is met or debug is enabled.
+func NewConditionalWriter(fields log.Fields, out Output, condition bool) io.Writer {
+	if condition || isDebug() {
 		return logWriter{
 			ctx: newLogger(fields),
 			out: out,

internal/pipe/sign/sign.go

@@ -185,8 +185,8 @@ func signone(ctx *context.Context, cfg config.Sign, art *artifact.Artifact) ([]*
 	cmd := exec.CommandContext(ctx, cfg.Cmd, args...)
 	var b bytes.Buffer
 	w := gio.Safe(&b)
-	cmd.Stderr = io.MultiWriter(logext.NewWriter(fields, logext.Error), w)
-	cmd.Stdout = io.MultiWriter(logext.NewWriter(fields, logext.Info), w)
+	cmd.Stderr = io.MultiWriter(logext.NewConditionalWriter(fields, logext.Error, cfg.Output), w)
+	cmd.Stdout = io.MultiWriter(logext.NewConditionalWriter(fields, logext.Info, cfg.Output), w)
 	if stdin != nil {
 		cmd.Stdin = stdin
 	}

pkg/config/config.go

@@ -631,6 +631,7 @@ type Sign struct {
 	StdinFile   string   `yaml:"stdin_file,omitempty"`
 	Env         []string `yaml:"env,omitempty"`
 	Certificate string   `yaml:"certificate,omitempty"`
+	Output      bool     `yaml:"output,omitempty"`
 }
 
 // SnapcraftAppMetadata for the binaries that will be in the snap package.

www/docs/customization/docker_sign.md

@@ -61,6 +61,12 @@ docker_signs:
     env:
     - FOO=bar
     - HONK=honkhonk
+
+    # By default, the stdout and stderr of the signing cmd are discarded unless GoReleaser is running with `--debug` set.
+    # You can set this to true if you want them to be displayed regardless.
+    #
+    # Defaults to false
+    output: true
 ```
 
 ### Available variable names

www/docs/customization/sign.md

@@ -97,6 +97,12 @@ signs:
     env:
     - FOO=bar
     - HONK=honkhonk
+
+    # By default, the stdout and stderr of the signing cmd are discarded unless GoReleaser is running with `--debug` set.
+    # You can set this to true if you want them to be displayed regardless.
+    #
+    # Defaults to false
+    output: true
 ```
 
 ### Available variable names