From 7cb8d622f5e53b178aa9fca498ffb89c35dd8b3b Mon Sep 17 00:00:00 2001 From: Carlos Alexandro Becker Date: Sat, 31 Aug 2019 10:27:04 -0300 Subject: [PATCH] fix: race condition on brew pipe (#1121) fixes #1120 Signed-off-by: Carlos Alexandro Becker --- internal/pipe/brew/brew.go | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/internal/pipe/brew/brew.go b/internal/pipe/brew/brew.go index 04fe64ba9..c375783ae 100644 --- a/internal/pipe/brew/brew.go +++ b/internal/pipe/brew/brew.go @@ -16,7 +16,6 @@ import ( "github.com/goreleaser/goreleaser/internal/client" "github.com/goreleaser/goreleaser/internal/deprecate" "github.com/goreleaser/goreleaser/internal/pipe" - "github.com/goreleaser/goreleaser/internal/semerrgroup" "github.com/goreleaser/goreleaser/internal/tmpl" "github.com/goreleaser/goreleaser/pkg/config" "github.com/goreleaser/goreleaser/pkg/context" @@ -46,14 +45,12 @@ func (Pipe) Publish(ctx *context.Context) error { if err != nil { return err } - var g = semerrgroup.New(ctx.Parallelism) for _, brew := range ctx.Config.Brews { - brew := brew - g.Go(func() error { - return doRun(ctx, brew, client) - }) + if err := doRun(ctx, brew, client); err != nil { + return err + } } - return g.Wait() + return nil } // Default sets the pipe defaults