diff --git a/internal/http/http.go b/internal/http/http.go index e57e86185..1097833a8 100644 --- a/internal/http/http.go +++ b/internal/http/http.go @@ -244,7 +244,7 @@ func uploadAssetToServer(ctx *context.Context, put *config.Put, target, username // newUploadRequest creates a new h.Request for uploading func newUploadRequest(target, username, secret string, headers map[string]string, a *asset) (*h.Request, error) { - req, err := h.NewRequest("PUT", target, a.ReadCloser) + req, err := h.NewRequest(h.MethodPut, target, a.ReadCloser) if err != nil { return nil, err } diff --git a/internal/pipe/artifactory/artifactory_test.go b/internal/pipe/artifactory/artifactory_test.go index 139ea8d0b..2f2960b2f 100644 --- a/internal/pipe/artifactory/artifactory_test.go +++ b/internal/pipe/artifactory/artifactory_test.go @@ -67,7 +67,7 @@ func TestRunPipe_ModeBinary(t *testing.T) { // Dummy artifactories mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==") @@ -93,7 +93,7 @@ func TestRunPipe_ModeBinary(t *testing.T) { }`) }) mux.HandleFunc("/example-repo-local/mybin/linux/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==") @@ -119,7 +119,7 @@ func TestRunPipe_ModeBinary(t *testing.T) { }`) }) mux.HandleFunc("/production-repo-remote/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "productionuser" with secret "productionuser-apikey" testHeader(t, r, "Authorization", "Basic cHJvZHVjdGlvbnVzZXI6cHJvZHVjdGlvbnVzZXItYXBpa2V5") @@ -145,7 +145,7 @@ func TestRunPipe_ModeBinary(t *testing.T) { }`) }) mux.HandleFunc("/production-repo-remote/mybin/linux/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "productionuser" with secret "productionuser-apikey" testHeader(t, r, "Authorization", "Basic cHJvZHVjdGlvbnVzZXI6cHJvZHVjdGlvbnVzZXItYXBpa2V5") @@ -248,7 +248,7 @@ func TestRunPipe_ModeArchive(t *testing.T) { // Dummy artifactories mux.HandleFunc("/example-repo-local/goreleaser/1.0.0/bin.tar.gz", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==") @@ -274,7 +274,7 @@ func TestRunPipe_ModeArchive(t *testing.T) { uploads.Store("targz", true) }) mux.HandleFunc("/example-repo-local/goreleaser/1.0.0/bin.deb", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==") @@ -388,7 +388,7 @@ func TestRunPipe_BadCredentials(t *testing.T) { // Dummy artifactories mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==") @@ -446,7 +446,7 @@ func TestRunPipe_UnparsableErrorResponse(t *testing.T) { // Dummy artifactories mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==") @@ -501,7 +501,7 @@ func TestRunPipe_UnparsableResponse(t *testing.T) { // Dummy artifactory with invalid JSON mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==") diff --git a/internal/pipe/put/put_test.go b/internal/pipe/put/put_test.go index 3a2422720..08aaab295 100644 --- a/internal/pipe/put/put_test.go +++ b/internal/pipe/put/put_test.go @@ -67,7 +67,7 @@ func TestRunPipe_ModeBinary(t *testing.T) { // Dummy http server mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==") @@ -76,7 +76,7 @@ func TestRunPipe_ModeBinary(t *testing.T) { w.WriteHeader(http.StatusCreated) }) mux.HandleFunc("/example-repo-local/mybin/linux/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==") @@ -85,7 +85,7 @@ func TestRunPipe_ModeBinary(t *testing.T) { w.WriteHeader(http.StatusCreated) }) mux.HandleFunc("/production-repo-remote/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "productionuser" with secret "productionuser-apikey" testHeader(t, r, "Authorization", "Basic cHJvZHVjdGlvbnVzZXI6cHJvZHVjdGlvbnVzZXItYXBpa2V5") @@ -94,7 +94,7 @@ func TestRunPipe_ModeBinary(t *testing.T) { w.WriteHeader(http.StatusCreated) }) mux.HandleFunc("/production-repo-remote/mybin/linux/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "productionuser" with secret "productionuser-apikey" testHeader(t, r, "Authorization", "Basic cHJvZHVjdGlvbnVzZXI6cHJvZHVjdGlvbnVzZXItYXBpa2V5") @@ -180,7 +180,7 @@ func TestRunPipe_ModeArchive(t *testing.T) { // Dummy http server mux.HandleFunc("/example-repo-local/goreleaser/1.0.0/bin.tar.gz", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==") @@ -189,7 +189,7 @@ func TestRunPipe_ModeArchive(t *testing.T) { uploads.Store("targz", true) }) mux.HandleFunc("/example-repo-local/goreleaser/1.0.0/bin.deb", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==") @@ -287,7 +287,7 @@ func TestRunPipe_BadCredentials(t *testing.T) { // Dummy http server mux.HandleFunc("/example-repo-local/mybin/darwin/amd64/mybin", func(w http.ResponseWriter, r *http.Request) { - testMethod(t, r, "PUT") + testMethod(t, r, http.MethodPut) testHeader(t, r, "Content-Length", "9") // Basic auth of user "deployuser" with secret "deployuser-secret" testHeader(t, r, "Authorization", "Basic ZGVwbG95dXNlcjpkZXBsb3l1c2VyLXNlY3JldA==")