From 846e26f48bf90b930cc29c6a4a490552f8e895cd Mon Sep 17 00:00:00 2001 From: Carlos Alexandro Becker Date: Sat, 27 Oct 2018 13:27:09 -0300 Subject: [PATCH] test: disable colors on tests --- internal/deprecate/deprecate_test.go | 32 +++++++++++++------ internal/deprecate/testdata/output.txt.golden | 3 ++ 2 files changed, 25 insertions(+), 10 deletions(-) create mode 100644 internal/deprecate/testdata/output.txt.golden diff --git a/internal/deprecate/deprecate_test.go b/internal/deprecate/deprecate_test.go index 21faa3e36..4394533a4 100644 --- a/internal/deprecate/deprecate_test.go +++ b/internal/deprecate/deprecate_test.go @@ -1,7 +1,8 @@ package deprecate import ( - "bytes" + "flag" + "io/ioutil" "testing" "github.com/apex/log" @@ -10,20 +11,31 @@ import ( "github.com/stretchr/testify/require" ) -func init() { - color.NoColor = true -} +var update = flag.Bool("update", false, "update .golden files") func TestNotice(t *testing.T) { - var out bytes.Buffer - cli.Default.Writer = &out - log.SetHandler(cli.Default) + f, err := ioutil.TempFile("", "output.txt") + require.NoError(t, err) + + color.NoColor = true + log.SetHandler(cli.New(f)) log.Info("first") Notice("foo.bar.whatever") log.Info("last") - require.Contains(t, out.String(), " • first") - require.Contains(t, out.String(), " • DEPRECATED: `foo.bar.whatever` should not be used anymore, check https://goreleaser.com/deprecations#foo-bar-whatever for more info.") - require.Contains(t, out.String(), " • last") + require.NoError(t, f.Close()) + + bts, err := ioutil.ReadFile(f.Name()) + require.NoError(t, err) + + const golden = "testdata/output.txt.golden" + if *update { + require.NoError(t, ioutil.WriteFile(golden, bts, 0655)) + } + + gbts, err := ioutil.ReadFile(golden) + require.NoError(t, err) + + require.Equal(t, string(gbts), string(bts)) } diff --git a/internal/deprecate/testdata/output.txt.golden b/internal/deprecate/testdata/output.txt.golden new file mode 100644 index 000000000..91ac6101d --- /dev/null +++ b/internal/deprecate/testdata/output.txt.golden @@ -0,0 +1,3 @@ + • first + • DEPRECATED: `foo.bar.whatever` should not be used anymore, check https://goreleaser.com/deprecations#foo-bar-whatever for more info. + • last