go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-02-01 13:07:49 +02:00
Code Issues Releases Activity

fix(gitlab): release file URL broken (#5035)

Browse Source 
<!--

Hi, thanks for contributing!

Please make sure you read our CONTRIBUTING guide.

Also, add tests and the respective documentation changes as well.

-->


<!-- If applied, this commit will... -->

Fix the GitLab upload URL.

<!-- Why is this change being made? -->
Gitlab changed upload URLs from 
`https://gitlab.com/{user}/{repo}/uploads/{hash}/file.ext` to
`https://gitlab.com/-/project/{projectID}/uploads/{hash}/file.ext`.

To avoid future issues like this the PR
https://github.com/xanzy/go-gitlab/pull/1968 was created upstream which
adds the `full_path` field to `go-gitlab` which this PR uses.

<!-- # Provide links to any relevant tickets, URLs or other resources
-->

Fixes https://github.com/goreleaser/goreleaser/issues/4974
This commit is contained in:
Adam Bouqdib 2024-08-03 17:56:42 +01:00 committed by GitHub
parent f301a10d96
commit 893562ca73
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
internal/client/gitlab.go
View File

@ -523,12 +523,7 @@ func (c *gitlabClient) Upload(
return fmt.Errorf("templating GitLab Download URL: %w", err)
}
// search for project details based on projectID
projectDetails, _, err := c.client.Projects.GetProject(projectID, nil)
if err != nil {
return err
}
linkURL = gitlabBaseURL + "/" + projectDetails.PathWithNamespace + baseLinkURL
linkURL = gitlabBaseURL + "/" + projectFile.FullPath
}
log.WithField("file", file.Name()).