go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-10-30 23:58:09 +02:00
Code Issues Releases Activity

refactor: using errors package properly

Browse Source 
The errors.Wrap already returns nil if the wrapped error is nil,
	therefore the if statement is unecessary.
This commit is contained in:
Carlos Alexandro Becker
2017-11-19 15:41:23 -02:00
committed by Carlos Alexandro Becker
parent 48ddd4c0eb
commit 8ae5d1563b
1 changed files with 2 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pipeline/build/build.go
View File

@@ -90,10 +90,7 @@ func runPipeOnBuild(ctx *context.Context, build config.Build) error {
if err := g.Wait(); err != nil {
return err
}
if err := runHook(build.Env, build.Hooks.Post); err != nil {
return errors.Wrap(err, "post hook failed")
}
return nil
return errors.Wrap(runHook(build.Env, build.Hooks.Post), "post hook failed")
}
func runHook(env []string, hook string) error {
@@ -131,10 +128,7 @@ func doBuild(ctx *context.Context, build config.Build, target buildtarget.Target
return err
}
cmd = append(cmd, "-ldflags="+flags, "-o", binary, build.Main)
if err := run(target, cmd, build.Env); err != nil {
return errors.Wrapf(err, "failed to build for %s", target)
}
return nil
return errors.Wrapf(run(target, cmd, build.Env), "failed to build for %s", target)
}
func run(target buildtarget.Target, command, env []string) error {