From 8c528a90b726fa3cf8e341ab4e1213626473875b Mon Sep 17 00:00:00 2001
From: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Date: Sat, 17 Feb 2018 14:28:48 -0200
Subject: [PATCH] fix: closing targz file (#563)

---
 pipeline/nfpm/nfpm.go | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/pipeline/nfpm/nfpm.go b/pipeline/nfpm/nfpm.go
index 826d9f6dd..d0df79fa5 100644
--- a/pipeline/nfpm/nfpm.go
+++ b/pipeline/nfpm/nfpm.go
@@ -56,15 +56,14 @@ func (Pipe) Run(ctx *context.Context) error {
 }
 
 func doRun(ctx *context.Context) error {
+	var linuxBinaries = ctx.Artifacts.Filter(artifact.And(
+		artifact.ByType(artifact.Binary),
+		artifact.ByGoos("linux"),
+	)).GroupByPlatform()
 	var g errgroup.Group
 	sem := make(chan bool, ctx.Parallelism)
 	for _, format := range ctx.Config.NFPM.Formats {
-		for platform, artifacts := range ctx.Artifacts.Filter(
-			artifact.And(
-				artifact.ByType(artifact.Binary),
-				artifact.ByGoos("linux"),
-			),
-		).GroupByPlatform() {
+		for platform, artifacts := range linuxBinaries {
 			sem <- true
 			format := format
 			arch := linux.Arch(platform)
@@ -107,6 +106,8 @@ func create(ctx *context.Context, format, arch string, binaries []artifact.Artif
 		Bindir:      ctx.Config.NFPM.Bindir,
 		// ConfigFiles: "" TODO: add this config_files to nfpm settings,
 	}
+
+	var log = log.WithField("package", name+"."+format)
 	for _, binary := range binaries {
 		src := binary.Path
 		dst := filepath.Join(ctx.Config.NFPM.Bindir, binary.Name)
@@ -125,9 +126,13 @@ func create(ctx *context.Context, format, arch string, binaries []artifact.Artif
 	if err != nil {
 		return err
 	}
+	defer w.Close() // nolint: errcheck
 	if err := packager.Package(nfpm.WithDefaults(info), w); err != nil {
 		return errors.Wrap(err, "nfpm failed")
 	}
+	if err := w.Close(); err != nil {
+		return errors.Wrap(err, "could not close package file")
+	}
 	ctx.Artifacts.Add(artifact.Artifact{
 		Type:   artifact.LinuxPackage,
 		Name:   name + "." + format,