Merge pull request #177 from goreleaser/checksums

better checksums

pipeline/checksums/checksums.go

@@ -4,8 +4,8 @@ package checksums
 
 import (
 	"fmt"
-	"io/ioutil"
 	"log"
+	"os"
 	"path/filepath"
 
 	"github.com/goreleaser/goreleaser/checksum"
@@ -23,31 +23,38 @@ func (Pipe) Description() string {
 
 // Run the pipe
 func (Pipe) Run(ctx *context.Context) (err error) {
+	file, err := os.OpenFile(
+		filepath.Join(
+			ctx.Config.Dist,
+			fmt.Sprintf("%v_checksums.txt", ctx.Config.Build.Binary),
+		),
+		os.O_APPEND|os.O_WRONLY|os.O_CREATE|os.O_TRUNC,
+		0644,
+	)
+	if err != nil {
+		return err
+	}
+	defer func() {
+		_ = file.Close()
+		ctx.AddArtifact(file.Name())
+	}()
 	var g errgroup.Group
 	for _, artifact := range ctx.Artifacts {
 		artifact := artifact
 		g.Go(func() error {
-			return checksums(ctx, artifact)
+			return checksums(ctx, file, artifact)
 		})
 	}
 	return g.Wait()
 }
 
-func checksums(ctx *context.Context, name string) error {
+func checksums(ctx *context.Context, file *os.File, name string) error {
 	log.Println("Checksumming", name)
 	var artifact = filepath.Join(ctx.Config.Dist, name)
 	sha, err := checksum.SHA256(artifact)
 	if err != nil {
 		return err
 	}
-	var file = filepath.Join(
+	_, err = file.WriteString(fmt.Sprintf("%v\t%v\n", sha, name))
-		ctx.Config.Dist,
+	return err
-		fmt.Sprintf("%v.%v", name, "checksums"),
-	)
-	var content = fmt.Sprintf("%v\t%v\n", sha, name)
-	if err := ioutil.WriteFile(file, []byte(content), 0644); err != nil {
-		return err
-	}
-	ctx.AddArtifact(file)
-	return nil
 }

pipeline/checksums/checksums_test.go

@@ -16,21 +16,26 @@ func TestDescription(t *testing.T) {
 
 func TestPipe(t *testing.T) {
 	var assert = assert.New(t)
+	var binary = "binary"
+	var checksums = binary + "_checksums.txt"
 	folder, err := ioutil.TempDir("", "goreleasertest")
 	assert.NoError(err)
-	var file = filepath.Join(folder, "binary")
+	var file = filepath.Join(folder, binary)
 	assert.NoError(ioutil.WriteFile(file, []byte("some string"), 0644))
 	var ctx = &context.Context{
 		Config: config.Project{
 			Dist: folder,
+			Build: config.Build{
+				Binary: binary,
+			},
 		},
 	}
 	ctx.AddArtifact(file)
 	assert.NoError(Pipe{}.Run(ctx))
-	assert.Contains(ctx.Artifacts, "binary.checksums", "binary")
+	assert.Contains(ctx.Artifacts, checksums, binary)
-	bts, err := ioutil.ReadFile(filepath.Join(folder, "binary.checksums"))
+	bts, err := ioutil.ReadFile(filepath.Join(folder, checksums))
 	assert.NoError(err)
-	assert.Contains(string(bts), "61d034473102d7dac305902770471fd50f4c5b26f6831a56dd90b5184b3c30fc	binary")
+	assert.Equal(string(bts), "61d034473102d7dac305902770471fd50f4c5b26f6831a56dd90b5184b3c30fc	binary\n")
 }
 
 func TestPipeFileNotExist(t *testing.T) {