diff --git a/pipeline/archive/archive.go b/pipeline/archive/archive.go index 31e2acaad..b7d35bfa7 100644 --- a/pipeline/archive/archive.go +++ b/pipeline/archive/archive.go @@ -119,8 +119,7 @@ func create(ctx *context.Context, artifacts []artifact.Artifact) error { func skip(ctx *context.Context, artifacts []artifact.Artifact) error { for _, a := range artifacts { log.WithField("binary", a.Name).Info("skip archiving") - // TODO: this should not happen here, maybe add another extra field - // for the extension and/or name without extension? + // TODO: this should not happen here, maybe add another extra field for the extension and/or name without extension? name, err := nametemplate.Apply(ctx, a, strings.TrimSuffix(a.Name, ".exe")) if err != nil { return err diff --git a/pipeline/brew/brew_test.go b/pipeline/brew/brew_test.go index 9066935f0..3fda0ba36 100644 --- a/pipeline/brew/brew_test.go +++ b/pipeline/brew/brew_test.go @@ -164,47 +164,6 @@ func TestRunPipe(t *testing.T) { }) } -// TODO: this test is irrelevant and can probavly be removed -func TestRunPipeFormatOverride(t *testing.T) { - folder, err := ioutil.TempDir("", "goreleasertest") - assert.NoError(t, err) - var path = filepath.Join(folder, "bin.zip") - _, err = os.Create(path) - assert.NoError(t, err) - var ctx = context.New( - config.Project{ - Dist: folder, - Archive: config.Archive{ - Format: "tar.gz", - FormatOverrides: []config.FormatOverride{ - { - Format: "zip", - Goos: "darwin", - }, - }, - }, - Brew: config.Homebrew{ - GitHub: config.Repo{ - Owner: "test", - Name: "test", - }, - }, - }, - ) - ctx.Publish = true - ctx.Artifacts.Add(artifact.Artifact{ - Name: "bin.zip", - Path: path, - Goos: "darwin", - Goarch: "amd64", - Type: artifact.UploadableArchive, - }) - client := &DummyClient{} - assert.NoError(t, doRun(ctx, client)) - assert.True(t, client.CreatedFile) - assert.Contains(t, client.Content, "bin.zip") -} - func TestRunPipeNoDarwin64Build(t *testing.T) { var ctx = &context.Context{ Config: config.Project{