go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-02-07 13:31:37 +02:00
Code Issues Releases Activity

Reorder defer'd closers

Browse Source 
Commit 40de5c5c64 introduces a regression (see comment) whereby
the tarball is closed before data is completely written, thus breaking the release package
This commit is contained in:
jspc 2017-01-03 20:14:26 +00:00
parent 4369eb3235
commit 9902043878
No known key found for this signature in database
GPG Key ID: 4C89C762E6A3982B
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
pipeline/compress/compress.go
View File

@ -44,9 +44,9 @@ func create(system, arch string, config config.ProjectConfig) error {
gw := gzip.NewWriter(file) gw := gzip.NewWriter(file)
tw := tar.NewWriter(gw) tw := tar.NewWriter(gw)
defer func() { defer func() {
_ = file.Close()
_ = gw.Close()
_ = tw.Close() _ = tw.Close()
_ = gw.Close()
_ = file.Close()
}() }()
for _, f := range config.Files { for _, f := range config.Files {
if err := addFile(tw, f, f); err != nil { if err := addFile(tw, f, f); err != nil {