From 9b4cf40ef676f26febb37c7c37ebcc3c204e3e6b Mon Sep 17 00:00:00 2001 From: Eli Young Date: Mon, 14 May 2018 17:00:49 -0700 Subject: [PATCH] test: Use multiple calls to assert.NotEmpty() assert.NotEmpty() was being used as if it would check multiple arguments. In actuality, it checks the second argument and, if it determines that it is empty, fails the test with an error message containing all subsequent arguments. --- pipeline/defaults/defaults_test.go | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/pipeline/defaults/defaults_test.go b/pipeline/defaults/defaults_test.go index f2173c538..0872f2b95 100644 --- a/pipeline/defaults/defaults_test.go +++ b/pipeline/defaults/defaults_test.go @@ -37,13 +37,10 @@ func TestFillBasicData(t *testing.T) { assert.Contains(t, ctx.Config.Brew.Install, "bin.install \"goreleaser\"") assert.Empty(t, ctx.Config.Dockers) assert.Equal(t, "https://github.com", ctx.Config.GitHubURLs.Download) - assert.NotEmpty( - t, - ctx.Config.Archive.NameTemplate, - ctx.Config.Builds[0].Ldflags, - ctx.Config.Archive.Files, - ctx.Config.Dist, - ) + assert.NotEmpty(t, ctx.Config.Archive.NameTemplate) + assert.NotEmpty(t, ctx.Config.Builds[0].Ldflags) + assert.NotEmpty(t, ctx.Config.Archive.Files) + assert.NotEmpty(t, ctx.Config.Dist) } func TestFillPartial(t *testing.T) {