fix: general cleanup

checksum/checksum.go

@@ -7,8 +7,6 @@ import (
 	"hash"
 	"io"
 	"os"
-
-	"github.com/apex/log"
 )
 
 // SHA256 sum of the given file
@@ -21,11 +19,7 @@ func calculate(hash hash.Hash, path string) (string, error) {
 	if err != nil {
 		return "", err
 	}
-	defer func() {
-		if err := file.Close(); err != nil {
-			log.WithError(err).Errorf("failed to close %s", path)
-		}
-	}()
+	defer file.Close() // nolint: errcheck
 
 	return doCalculate(hash, file)
 }

pipeline/archive/archive.go

@@ -77,18 +77,10 @@ func create(ctx *context.Context, artifacts []artifact.Artifact) error {
 	if err != nil {
 		return fmt.Errorf("failed to create directory %s: %s", archivePath, err.Error())
 	}
-	defer func() {
-		if e := archiveFile.Close(); e != nil {
-			log.WithField("archive", archivePath).Errorf("failed to close file: %v", e)
-		}
-	}()
+	defer archiveFile.Close() // nolint: errcheck
 	log.WithField("archive", archivePath).Info("creating")
 	var a = archive.New(archiveFile)
-	defer func() {
-		if e := a.Close(); e != nil {
-			log.WithField("archive", archivePath).Errorf("failed to close archive: %v", e)
-		}
-	}()
+	defer a.Close() // nolint: errcheck
 
 	files, err := findFiles(ctx)
 	if err != nil {

pipeline/checksums/checksums.go

@@ -42,16 +42,8 @@ func (Pipe) Run(ctx *context.Context) (err error) {
 	if err != nil {
 		return err
 	}
-	defer func() {
-		if err := file.Close(); err != nil {
-			log.WithError(err).Errorf("failed to close %s", file.Name())
-		}
-		ctx.Artifacts.Add(artifact.Artifact{
-			Type: artifact.Checksum,
-			Path: file.Name(),
-			Name: filename,
-		})
-	}()
+	defer file.Close() // nolint: errcheck
+
 	// TODO: parallelism should be considered here as well.
 	var g errgroup.Group
 	for _, artifact := range ctx.Artifacts.Filter(
@@ -66,6 +58,11 @@ func (Pipe) Run(ctx *context.Context) (err error) {
 			return checksums(ctx, file, artifact)
 		})
 	}
+	ctx.Artifacts.Add(artifact.Artifact{
+		Type: artifact.Checksum,
+		Path: file.Name(),
+		Name: filename,
+	})
 	return g.Wait()
 }
 

pipeline/release/release.go

@@ -87,7 +87,7 @@ func upload(ctx *context.Context, c client.Client, releaseID int, artifact artif
 	if err != nil {
 		return err
 	}
-	defer func() { _ = file.Close() }()
+	defer file.Close() // nolint: errcheck
 	log.WithField("file", file.Name()).WithField("name", artifact.Name).Info("uploading to release")
 	return c.Upload(ctx, releaseID, artifact.Name, file)
 }