go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-03-17 20:47:50 +02:00
Code Issues Releases Activity

fix: make latest on drafts (#4966)

Browse Source 
this seems to fix the #4961
This commit is contained in:
Carlos Alexandro Becker 2024-06-29 19:42:20 -03:00 committed by GitHub
parent 8e9f2691ea
commit 9d513696c2
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
internal/client/github.go
View File

@ -387,7 +387,6 @@ func (c *githubClient) CreateRelease(ctx *context.Context, body string) (string,
// PublishRelease will undraft it.
Draft: github.Bool(true),
Prerelease: github.Bool(ctx.PreRelease),
MakeLatest: github.String("true"),
}
if target := ctx.Config.Release.TargetCommitish; target != "" {
@ -400,15 +399,12 @@ func (c *githubClient) CreateRelease(ctx *context.Context, body string) (string,
}
}
if latest := strings.TrimSpace(ctx.Config.Release.MakeLatest); latest == "false" {
data.MakeLatest = github.String(latest)
}
release, err := c.createOrUpdateRelease(ctx, data, body)
if err != nil {
return "", fmt.Errorf("could not release: %w", err)
}
log.WithField("url", release.GetHTMLURL()).Info("created")
return strconv.FormatInt(release.GetID(), 10), nil
}
@ -424,12 +420,17 @@ func (c *githubClient) PublishRelease(ctx *context.Context, releaseID string) er
data := &github.RepositoryRelease{
Draft: github.Bool(draft),
}
if latest := strings.TrimSpace(ctx.Config.Release.MakeLatest); latest != "" {
data.MakeLatest = github.String(latest)
}
if ctx.Config.Release.DiscussionCategoryName != "" {
data.DiscussionCategoryName = github.String(ctx.Config.Release.DiscussionCategoryName)
}
if _, err := c.updateRelease(ctx, releaseIDInt, data); err != nil {
release, err := c.updateRelease(ctx, releaseIDInt, data)
if err != nil {
return fmt.Errorf("could not update existing release: %w", err)
}
log.WithField("url", release.GetHTMLURL()).Info("published")
return nil
}