go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-02-09 13:36:56 +02:00
Code Issues Releases Activity

fix: Completer script link errors for snapcraft (#1679)

Browse Source
This commit is contained in:
Aggelos Kolaitis 2020-07-17 22:11:08 +03:00 committed by GitHub
parent d798106316
commit a69b525ddb
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/pipe/snapcraft/snapcraft.go
View File

@ -270,7 +270,7 @@ func create(ctx *context.Context, snap config.Snapcraft, arch string, binaries [
log.WithField("src", config.Completer).
WithField("dst", destCompleterPath).
Debug("linking")
if err := os.Link(config.Completer, destCompleterPath); err != nil {
if err := os.Link(config.Completer, destCompleterPath); err != nil && !os.IsExist(err) {
return errors.Wrap(err, "failed to link completer")
}
if err := os.Chmod(destCompleterPath, 0644); err != nil {

3
internal/pipe/snapcraft/snapcraft_test.go
View File

@ -311,13 +311,14 @@ func TestCompleter(t *testing.T) {
Completer: "testdata/mybin-completer.bash",
},
},
Builds: []string{"foo"},
Builds: []string{"foo", "bar"},
},
},
})
ctx.Git.CurrentTag = "v1.2.3"
ctx.Version = "v1.2.3"
addBinaries(t, ctx, "foo", dist, "mybin")
addBinaries(t, ctx, "bar", dist, "mybin")
require.NoError(t, Pipe{}.Run(ctx))
yamlFile, err := ioutil.ReadFile(filepath.Join(dist, "foo_amd64", "prime", "meta", "snap.yaml"))
require.NoError(t, err)