diff --git a/pipeline/snapcraft/snapcraft.go b/pipeline/snapcraft/snapcraft.go index e803b1cf8..30eb1b7d8 100644 --- a/pipeline/snapcraft/snapcraft.go +++ b/pipeline/snapcraft/snapcraft.go @@ -52,7 +52,7 @@ func (Pipe) Run(ctx *context.Context) error { log.Error("no snapcraft summary defined, skipping") return nil } - if ctx.Config.Snapcraft.Summary == "" { + if ctx.Config.Snapcraft.Description == "" { log.Error("no snapcraft description defined, skipping") return nil } diff --git a/pipeline/snapcraft/snapcraft_test.go b/pipeline/snapcraft/snapcraft_test.go index 5faa1fcab..79b475617 100644 --- a/pipeline/snapcraft/snapcraft_test.go +++ b/pipeline/snapcraft/snapcraft_test.go @@ -31,6 +31,8 @@ func TestRunPipeMissingInfo(t *testing.T) { Snapcraft: snap, }, } + // FIXME: there is no way to tell here if the pipe actually ran + // or if it was indeed skipped. assert.NoError(Pipe{}.Run(ctx)) }) } @@ -54,7 +56,7 @@ func TestRunPipe(t *testing.T) { }, }, } - for _, plat := range []string{"linuxamd64", "linux386", "darwinamd64"} { + for _, plat := range []string{"linuxamd64", "linux386", "darwinamd64", "linuxarm64", "linuxarmhf"} { var folder = "mybin_" + plat assert.NoError(os.Mkdir(filepath.Join(dist, folder), 0755)) var binPath = filepath.Join(dist, folder, "mybin")