go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-01-30 04:50:45 +02:00
Code Issues Releases Activity

test: add missing file.Close() calls (#5167)

Browse Source 
This PR adds missing `file.Close()` calls in tests. All files that are
opened using `os.Open` should be closed after finishing reading.
This commit is contained in:
Oleksandr Redko 2024-10-03 20:37:29 +03:00 committed by GitHub
parent b8aef100f2
commit c1f8b686db
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
3 changed files with 61 additions and 36 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

72
internal/client/github_test.go
View File

@ -273,9 +273,11 @@ func TestGitHubChangelog(t *testing.T) {
if r.URL.Path == "/repos/someone/something/compare/v1.0.0...v1.1.0" {
r, err := os.Open("testdata/github/compare.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
}
if r.URL.Path == "/rate_limit" {
@ -318,9 +320,11 @@ func TestGitHubReleaseNotes(t *testing.T) {
if r.URL.Path == "/repos/someone/something/releases/generate-notes" {
r, err := os.Open("testdata/github/releasenotes.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
}
if r.URL.Path == "/rate_limit" {
@ -388,9 +392,11 @@ func TestGitHubCloseMilestone(t *testing.T) {
if r.URL.Path == "/repos/someone/something/milestones" {
r, err := os.Open("testdata/github/milestones.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
}
@ -442,9 +448,11 @@ func TestGitHubOpenPullRequestCrossRepo(t *testing.T) {
assert.Equal(t, "someoneelse:something:foo", pr.GetHead())
assert.Equal(t, testPRTemplate+"\n"+prFooter, pr.GetBody())
r, err := os.Open("testdata/github/pull.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
}
@ -494,9 +502,11 @@ func TestGitHubOpenPullRequestHappyPath(t *testing.T) {
if r.URL.Path == "/repos/someone/something/pulls" {
r, err := os.Open("testdata/github/pull.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
}
@ -545,9 +555,11 @@ func TestGitHubOpenPullRequestNoBaseBranchDraft(t *testing.T) {
assert.True(t, pr.GetDraft())
r, err := os.Open("testdata/github/pull.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
}
@ -596,9 +608,11 @@ func TestGitHubOpenPullRequestPRExists(t *testing.T) {
if r.URL.Path == "/repos/someone/something/pulls" {
w.WriteHeader(http.StatusUnprocessableEntity)
r, err := os.Open("testdata/github/pull.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
}
@ -639,9 +653,11 @@ func TestGitHubOpenPullRequestBaseEmpty(t *testing.T) {
if r.URL.Path == "/repos/someone/something/pulls" {
r, err := os.Open("testdata/github/pull.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
}
@ -688,9 +704,11 @@ func TestGitHubOpenPullRequestHeadEmpty(t *testing.T) {
if r.URL.Path == "/repos/someone/something/pulls" {
r, err := os.Open("testdata/github/pull.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
}

24
internal/client/gitlab_test.go
View File

@ -486,9 +486,11 @@ func TestGitLabChangelog(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if strings.HasSuffix(r.URL.Path, "projects/someone/something/repository/compare") {
r, err := os.Open("testdata/gitlab/compare.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
}
defer r.Body.Close()
@ -652,15 +654,19 @@ func TestGitLabCloseMilestone(t *testing.T) {
srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
if strings.HasSuffix(r.URL.Path, "projects/someone/something/milestones") {
r, err := os.Open("testdata/gitlab/milestones.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
} else if strings.HasSuffix(r.URL.Path, "projects/someone/something/milestones/12") {
r, err := os.Open("testdata/gitlab/milestone.json")
assert.NoError(t, err)
_, err = io.Copy(w, r)
assert.NoError(t, err)
if assert.NoError(t, err) {
defer r.Close()
_, err = io.Copy(w, r)
assert.NoError(t, err)
}
return
}
defer r.Body.Close()

1
internal/testlib/archive.go
View File

@ -148,5 +148,6 @@ func openFile(tb testing.TB, path string) *os.File {
tb.Helper()
f, err := os.Open(path)
require.NoError(tb, err)
tb.Cleanup(func() { f.Close() })
return f
}