From ca35acf43406cf069d07ea888e4c71f1a95d73d0 Mon Sep 17 00:00:00 2001 From: Carlos Alexandro Becker Date: Mon, 25 Dec 2017 23:28:09 -0200 Subject: [PATCH] feat: docker in parallel --- internal/artifact/artifact.go | 2 -- pipeline/docker/docker.go | 1 - 2 files changed, 3 deletions(-) diff --git a/internal/artifact/artifact.go b/internal/artifact/artifact.go index db430249a..1458f179a 100644 --- a/internal/artifact/artifact.go +++ b/internal/artifact/artifact.go @@ -141,8 +141,6 @@ func And(filters ...Filter) Filter { // is accepted. // You can compose filters by using the And and Or filters. func (artifacts *Artifacts) Filter(filter Filter) Artifacts { - // TODO: this could be done lazily and the real job could be done in the - // #List() method maybe? var result = New() for _, a := range artifacts.items { if filter(a) { diff --git a/pipeline/docker/docker.go b/pipeline/docker/docker.go index 749f1f9fb..a379c547d 100644 --- a/pipeline/docker/docker.go +++ b/pipeline/docker/docker.go @@ -175,7 +175,6 @@ func link(src, dest string) error { } func publish(ctx *context.Context, docker config.Docker, image, latest string) error { - // TODO: improve this so it can log it to stdout if !ctx.Publish { log.Warn("skipping push because --skip-publish is set") return nil