go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-01-04 03:11:55 +02:00
Code Issues Releases Activity

fix: goreleaser build index out of range (#4007)

Browse Source 
If you run `goreleaser build --single-target` with
`universalbinaries[*].replace = true` on a mac, it'll break.

This fixes it by disabling universal binaries when building a single
target.

It isn't useful anyway.

Closes #4004

Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
This commit is contained in:
Carlos Alexandro Becker 2023-05-12 15:50:12 -03:00 committed by GitHub
parent f0dfdb8732
commit cebdf0d8a6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
cmd/build.go
View File

@ -178,6 +178,7 @@ func setupBuildSingleTarget(ctx *context.Context) {
build.Goamd64 = nil
build.Targets = nil
}
ctx.Config.UniversalBinaries = nil
}
func setupBuildID(ctx *context.Context, ids []string) error {
@ -214,7 +215,11 @@ func (w withOutputPipe) String() string {
}
func (w withOutputPipe) Run(ctx *context.Context) error {
path := ctx.Artifacts.Filter(artifact.ByType(artifact.Binary)).List()[0].Path
bins := ctx.Artifacts.Filter(artifact.ByType(artifact.Binary)).List()
if len(bins) == 0 {
return fmt.Errorf("no binary found")
}
path := bins[0].Path
out := w.output
if out == "." {
out = filepath.Base(path)

8
cmd/build_test.go
View File

@ -292,15 +292,19 @@ func TestBuildSingleTargetWithSpecificTargets(t *testing.T) {
},
},
},
UniversalBinaries: []config.UniversalBinary{
{Replace: true},
},
})
t.Setenv("GOOS", "linux")
t.Setenv("GOOS", "darwin")
t.Setenv("GOARCH", "amd64")
setupBuildSingleTarget(ctx)
require.Equal(t, config.Build{
Goos: []string{"linux"},
Goos: []string{"darwin"},
Goarch: []string{"amd64"},
}, ctx.Config.Builds[0])
require.Nil(t, ctx.Config.UniversalBinaries)
}
func TestBuildSingleTargetRemoveOtherOptions(t *testing.T) {