go/goreleaser
go/goreleaser
1
0
Fork 0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-03-19 20:57:53 +02:00
Code Issues Releases Activity

feat: update x/sync (#3138)

Browse Source 
* feat: update x/sync

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

* test: fixes

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

* fix: revert

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>

* test: fix race condition

Signed-off-by: Carlos A Becker <caarlos0@users.noreply.github.com>
This commit is contained in:
Carlos Alexandro Becker 2022-06-11 16:54:55 -03:00 committed by GitHub
parent 1a8e075e4f
commit df734bd111
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 55 additions and 90 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
go.mod
View File

@ -36,7 +36,7 @@ require (
gocloud.dev v0.24.0
golang.org/x/crypto v0.0.0-20220307211146-efcb8507fb70
golang.org/x/oauth2 v0.0.0-20220411215720-9780585627b5
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c
golang.org/x/sync v0.0.0-20220513210516-0976fa681c29
gopkg.in/mail.v2 v2.3.1
gopkg.in/yaml.v3 v3.0.1
)

3
go.sum
View File

@ -844,8 +844,9 @@ golang.org/x/sync v0.0.0-20200317015054-43a5402ce75a/go.mod h1:RxMgew5VJxzue5/jJ
golang.org/x/sync v0.0.0-20200625203802-6e8e738ad208/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20201020160332-67f06af15bc9/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20201207232520-09787c993a3a/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c h1:5KslGYwFpkhGh+Q16bwMP3cOontH8FOep7tGV86Y7SQ=
golang.org/x/sync v0.0.0-20210220032951-036812b2e83c/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sync v0.0.0-20220513210516-0976fa681c29 h1:w8s32wxx3sY+OjLlv9qltkLU5yvJzxjjgiHWLjdIcw4=
golang.org/x/sync v0.0.0-20220513210516-0976fa681c29/go.mod h1:RxMgew5VJxzue5/jJTE5uejpjVlOe/izrB70Jof72aM=
golang.org/x/sys v0.0.0-20180823144017-11551d06cbcc/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20180830151530-49385e6e1522/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=
golang.org/x/sys v0.0.0-20180905080454-ebe1bf3edb33/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY=

57
internal/semerrgroup/sem.go
View File

@ -17,60 +17,9 @@ type Group interface {
// New returns a new Group of a given size.
func New(size int) Group {
if size == 1 {
return &serialGroup{}
}
return &parallelGroup{
ch: make(chan bool, size),
g: errgroup.Group{},
}
}
var _ Group = &parallelGroup{}
type parallelGroup struct {
ch chan bool
g errgroup.Group
}
// Go execs one function respecting the group and semaphore.
func (s *parallelGroup) Go(fn func() error) {
s.g.Go(func() error {
s.ch <- true
defer func() {
<-s.ch
}()
return fn()
})
}
// Wait waits for the group to complete and return an error if any.
func (s *parallelGroup) Wait() error {
return s.g.Wait()
}
var _ Group = &serialGroup{}
type serialGroup struct {
err error
errOnce sync.Once
}
// Go execs runs `fn` and saves the result if no error has been encountered.
func (s *serialGroup) Go(fn func() error) {
if s.err != nil {
return
}
if err := fn(); err != nil {
s.errOnce.Do(func() {
s.err = err
})
}
}
// Wait waits for Go to complete and returns the first error encountered.
func (s *serialGroup) Wait() error {
return s.err
var g errgroup.Group
g.SetLimit(size)
return &g
}
var _ Group = &skipAwareGroup{}

83
internal/semerrgroup/sem_test.go
View File

@ -11,20 +11,24 @@ import (
)
func TestSemaphore(t *testing.T) {
g := New(4)
var lock sync.Mutex
var counter int
for i := 0; i < 10; i++ {
g.Go(func() error {
time.Sleep(10 * time.Millisecond)
lock.Lock()
counter++
lock.Unlock()
return nil
for _, i := range []int{1, 4} {
t.Run(fmt.Sprintf("limit-%d", i), func(t *testing.T) {
g := New(i)
var lock sync.Mutex
var counter int
for i := 0; i < 10; i++ {
g.Go(func() error {
time.Sleep(10 * time.Millisecond)
lock.Lock()
counter++
lock.Unlock()
return nil
})
}
require.NoError(t, g.Wait())
require.Equal(t, counter, 10)
})
}
require.NoError(t, g.Wait())
require.Equal(t, counter, 10)
}
func TestSemaphoreOrder(t *testing.T) {
@ -42,35 +46,46 @@ func TestSemaphoreOrder(t *testing.T) {
require.Equal(t, []int{0, 1, 2, 3, 4, 5, 6, 7, 8, 9}, output)
}
func TestSemaphoreOrderError(t *testing.T) {
g := New(1)
output := []int{}
for i := 0; i < 10; i++ {
i := i
g.Go(func() error {
output = append(output, i)
return fmt.Errorf("fake err")
func TestSemaphoreError(t *testing.T) {
for _, i := range []int{1, 4} {
t.Run(fmt.Sprintf("limit-%d", i), func(t *testing.T) {
g := New(i)
var lock sync.Mutex
output := []int{}
for i := 0; i < 10; i++ {
i := i
g.Go(func() error {
lock.Lock()
defer lock.Unlock()
output = append(output, i)
return fmt.Errorf("fake err")
})
}
require.EqualError(t, g.Wait(), "fake err")
require.Len(t, output, 10)
})
}
require.EqualError(t, g.Wait(), "fake err")
require.Equal(t, []int{0}, output)
}
func TestSemaphoreSkipAware(t *testing.T) {
g := NewSkipAware(New(1))
var lock sync.Mutex
var counter int
for i := 0; i < 10; i++ {
g.Go(func() error {
time.Sleep(10 * time.Millisecond)
lock.Lock()
counter++
lock.Unlock()
return pipe.Skip("fake skip")
for _, i := range []int{1, 4} {
t.Run(fmt.Sprintf("limit-%d", i), func(t *testing.T) {
g := NewSkipAware(New(i))
var lock sync.Mutex
var counter int
for i := 0; i < 10; i++ {
g.Go(func() error {
time.Sleep(10 * time.Millisecond)
lock.Lock()
counter++
lock.Unlock()
return pipe.Skip("fake skip")
})
}
require.EqualError(t, g.Wait(), "fake skip")
require.Equal(t, counter, 10)
})
}
require.EqualError(t, g.Wait(), "fake skip")
require.Equal(t, counter, 10)
}
func TestSemaphoreSkipAndRealError(t *testing.T) {