diff --git a/pipeline/brew/brew_test.go b/pipeline/brew/brew_test.go index 7c19d747b..fab9a891d 100644 --- a/pipeline/brew/brew_test.go +++ b/pipeline/brew/brew_test.go @@ -30,9 +30,10 @@ func TestSimpleName(t *testing.T) { } var defaultTemplateData = templateData{ - Desc: "Some desc", - Homepage: "https://google.com", - Name: "Test", + Desc: "Some desc", + Homepage: "https://google.com", + DownloadURL: "https://github.com", + Name: "Test", Repo: config.Repo{ Owner: "caarlos0", Name: "test", @@ -46,10 +47,10 @@ var defaultTemplateData = templateData{ func assertDefaultTemplateData(t *testing.T, formulae string) { assert := assert.New(t) assert.Contains(formulae, "class Test < Formula") - assert.Contains(formulae, "homepage \"https://google.com\"") - assert.Contains(formulae, "url \"https://github.com/caarlos0/test/releases/download/v0.1.3/test_Darwin_x86_64.tar.gz\"") - assert.Contains(formulae, "sha256 \"1633f61598ab0791e213135923624eb342196b3494909c91899bcd0560f84c68\"") - assert.Contains(formulae, "version \"0.1.3\"") + assert.Contains(formulae, `homepage "https://google.com"`) + assert.Contains(formulae, `url "https://github.com/caarlos0/test/releases/download/v0.1.3/test_Darwin_x86_64.tar.gz"`) + assert.Contains(formulae, `sha256 "1633f61598ab0791e213135923624eb342196b3494909c91899bcd0560f84c68"`) + assert.Contains(formulae, `version "0.1.3"`) } func TestFullFormulae(t *testing.T) { @@ -65,10 +66,9 @@ func TestFullFormulae(t *testing.T) { assert.NoError(err) formulae := out.String() - f, err := os.Open("testdata/test.rb") - assert.NoError(err) - bts, err := ioutil.ReadAll(f) + bts, err := ioutil.ReadFile("testdata/test.rb") assert.NoError(err) + // ioutil.WriteFile("testdata/test.rb", []byte(formulae), 0644) assert.Equal(string(bts), formulae) } @@ -141,7 +141,7 @@ func TestRunPipe(t *testing.T) { bts, err := ioutil.ReadFile("testdata/run_pipe.rb") assert.NoError(err) - assert.NoError(ioutil.WriteFile("testdata/run_pipe.rb", []byte(client.Content), 0644)) + // assert.NoError(ioutil.WriteFile("testdata/run_pipe.rb", []byte(client.Content), 0644)) assert.Equal(string(bts), client.Content) } diff --git a/pipeline/brew/template.go b/pipeline/brew/template.go index 6eb679f52..ca26a839f 100644 --- a/pipeline/brew/template.go +++ b/pipeline/brew/template.go @@ -23,8 +23,7 @@ type templateData struct { const formulaTemplate = `class {{ .Name }} < Formula desc "{{ .Desc }}" homepage "{{ .Homepage }}" - url "{{ .DownloadsURL }}/{{ .Repo.Owner }}/{{ .Repo.Name }}/releases/download/{{ .Tag }}/{{ .File }}" - + url "{{ .DownloadURL }}/{{ .Repo.Owner }}/{{ .Repo.Name }}/releases/download/{{ .Tag }}/{{ .File }}" version "{{ .Version }}" sha256 "{{ .SHA256 }}" diff --git a/pipeline/brew/testdata/run_pipe.rb b/pipeline/brew/testdata/run_pipe.rb index 0fb1100b8..bb488bea5 100644 --- a/pipeline/brew/testdata/run_pipe.rb +++ b/pipeline/brew/testdata/run_pipe.rb @@ -1,7 +1,7 @@ class RunPipe < Formula desc "A run pipe test formula" homepage "https://github.com/goreleaser" - url "https://github.com///releases/download/v1.0.1/bin.tar.gz" + url "https://github.com/test/test/releases/download/v1.0.1/bin.tar.gz" version "1.0.1" sha256 "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"