<!--
Hi, thanks for contributing!
Please make sure you read our CONTRIBUTING guide.
Also, add tests and the respective documentation changes as well.
-->
<!-- If applied, this commit will... -->
...
<!-- Why is this change being made? -->
Brew linter says that old constructions can't be used in case of
submitting to brew-core
<!-- # Provide links to any relevant tickets, URLs or other resources
-->
...
<!--
Hi, thanks for contributing!
Please make sure you read our CONTRIBUTING guide.
Also, add tests and the respective documentation changes as well.
-->
<!-- If applied, this commit will... -->
Fix the order in which brew artifacts are sorted.
<!-- Why is this change being made? -->
* The order occasionally switches, which results in a larger diff:
https://github.com/confluentinc/homebrew-tap/pull/41
* The artifacts are already grouped by OS before `lessFnFor()` is
called, so `list[i].OS > list[j].OS` always evaluates to `false` and the
order remains unchanged. This PR removes that statement.
* It looks like a `map` is used earlier, while filtering the artifacts,
which might explain why the order occasionally switches.
* Update the remaining statement in `lessFnFor()` to actually use `<` as
the function suggests.
<!-- # Provide links to any relevant tickets, URLs or other resources
-->
Currently on a M1 macbook when adding a tap with formulas that only support amd64 it fails to add the tap. This prevents new arm64 users from using the tap. By allowing arm64 users to install an amd64 binary if no arm64 binary is avialable will atleast allow the user to use the tap.
* fix(brew): Remove deprecated `bottle :unneeded`
Fixes this warning from Homebrew:
`Warning: Calling bottle :unneeded is deprecated! There is no replacement.`
* fix(brew): fix regression that added newlines to formula
* feat(brew): multi-arch brew on binary archives
also fixes brew taps when archives have different binaries in each platform (e.g. some binary is only on the linux archives for some reason)
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
* Update internal/pipe/brew/template.go
Co-authored-by: Radek Simko <radek.simko@gmail.com>
* fix: spacing
Co-authored-by: Radek Simko <radek.simko@gmail.com>
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
Co-authored-by: Radek Simko <radek.simko@gmail.com>
* refactor: improve brew templates
based on #2509
Co-authored-by: Engin Diri <engin.diri@mail.schwarz>
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* fix: improve templates a bit
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* refactor: improve check
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* refactor: improve less
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
* refactor: improve counts
Signed-off-by: Carlos Alexandro Becker <caarlos0@gmail.com>
Co-authored-by: Engin Diri <engin.diri@mail.schwarz>
* feat: release header/footer
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
* feat: release header/footer
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
* refactor: using the golden library all over
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
* fix: lint
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
* fix: brew arm tests
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
* fix: use footer
Signed-off-by: Carlos A Becker <caarlos0@gmail.com>
