1
0
mirror of https://github.com/goreleaser/goreleaser.git synced 2025-01-10 03:47:03 +02:00
Commit Graph

7 Commits

Author SHA1 Message Date
Andy Grunwald
0b0c12aaad fix: Adjusted codebase according comments from @caarlos0
- Renamed function to upload()
- Fixed an inline comment
- Excluded a defer file.Close() from errcheck analysis
2017-12-02 23:39:39 +01:00
Andy Grunwald
78f83ec466 test: Add three new unit tests for Artifactory pipeline
Three new unit tests added:
- TestRunPipe_NoFile: Checks the error if the file for the
upload is not there
- TestRunPipe_UnparsableTarget: Checks that an error will
be thrown if the target is not parsable
- TestRunPipe_DirUpload: Checks that an error will be
thrown when we try to upload a directory
2017-12-02 22:03:01 +01:00
Andy Grunwald
2842b86365 fix: Don't continue Artifactory pipeline when there is an error
We are able to define multiple Artifactory instances.
In the former implementation, we continue once one instance upload
was failing. Now we stop and throw the error.
2017-12-02 21:40:14 +01:00
Andy Grunwald
37bc09f2bc fix: Use HTTP error if upload to Artifactory failes
In a former commit we respected the error of the Close()
call for a HTTP response. The fix was to introduce named
return values (e.g. err for error).
The problem: We defered the resp.Close() via
err = resp.Close()
This had the effect of always overwrite the real error
that happen when the HTTP call failes (due to checkResponse func).
2017-12-02 21:29:59 +01:00
Andy Grunwald
024ca0a1af fix: panic while access a http response in Artifactory pipeline
When the upload target is not resolvable by tcp (e.g. unknown host)
no response object will be generated.
In an error case the response object is used (it was assumed that
this will be there at every point in time).

This commit fixes this behaviour
2017-12-02 21:10:32 +01:00
Andy Grunwald
c1d2c28b0a fix: gometalinter warnings for Artifactory pipeline
gometalinter had several warnings about not respected
err return values from Close() calls
2017-12-02 20:47:02 +01:00
Andy Grunwald
492a018b7f feat: Added basic support to push binaries into Artifactory
Artifactory is an universal Artifact Repository Manager by
JFrog. See https://www.jfrog.com/artifactory/

It is available in an OSS and Enterprise version.
Many companies using this internally to store, manage and
distribute binaries within their internal infrastructure.

It adds basic support to push all generated binaries into an
Artifactory. Basic means only the built artifacts. Without
checksums or archives.
As an authentication only Basic auth is supported by this Pipe.

See #344
2017-12-02 20:26:55 +01:00