We have been using `t.Setenv` is most of our tests. This PR replaces the
remaining `os.Setenv` with `t.Setenv`.
Reference: https://pkg.go.dev/testing#T.Setenv
```go
func TestFoo(t *testing.T) {
// before
os.Setenv(key, "new value")
defer os.Unsetenv(key)
// after
t.Setenv(key, "new value")
}
```
---------
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
It will otherwise create the empty fields in the yaml, and snapcraft
then complains they are empty and fail.
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
mimic the structure to be created in the target repo, and put each of
them in its own folder.
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
nfpm was updated, but we never allowed to configure the umask field in
goreleaser.
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Behavior of the `EXIT` condition is not consistent between shells with
regards to abnormal exits and signals. This cleanup should occur always.
https://austingroupbugs.net/view.php?id=621
Bumps [github.com/xanzy/go-gitlab](https://github.com/xanzy/go-gitlab)
from 0.85.0 to 0.86.0.
<details>
<summary>Commits</summary>
<ul>
<li><a
href="0886867b3b"><code>0886867</code></a>
Update CI and CONTRIBUTION.md</li>
<li><a
href="57a8f8f705"><code>57a8f8f</code></a>
Fix two linter warnings</li>
<li><a
href="d4057c786d"><code>d4057c7</code></a>
Merge pull request <a
href="https://redirect.github.com/xanzy/go-gitlab/issues/1646">#1646</a>
from theoriginalstove/1643-contributing-guide</li>
<li><a
href="c1a78fc6ad"><code>c1a78fc</code></a>
Merge pull request <a
href="https://redirect.github.com/xanzy/go-gitlab/issues/1740">#1740</a>
from PatrickRice-KSC/add-admin-permission-const</li>
<li><a
href="9f3d9fad76"><code>9f3d9fa</code></a>
Add admin permission const</li>
<li><a
href="85fa21c71b"><code>85fa21c</code></a>
Merge pull request <a
href="https://redirect.github.com/xanzy/go-gitlab/issues/1732">#1732</a>
from Mareo/add-support-for-discord-service</li>
<li><a
href="1a7fd5cf74"><code>1a7fd5c</code></a>
Update README.md</li>
<li><a
href="39ca669228"><code>39ca669</code></a>
Update CONTRIBUTING.md</li>
<li><a
href="9fc3c91b5d"><code>9fc3c91</code></a>
Add support for Discord service</li>
<li>See full diff in <a
href="https://github.com/xanzy/go-gitlab/compare/v0.85.0...v0.86.0">compare
view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/xanzy/go-gitlab&package-manager=go_modules&previous-version=0.85.0&new-version=0.86.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
closes#3989
Basically, when some of these pipes fail, the error will be memorized,
and all errors will be thrown in the end.
Meaning: the exit code will still be 1, but it'll not have stopped in
the first error.
Thinking of maybe adding a `--fail-fast` flag to disable this behavior
as well 🤔
---------
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Bumps [gocloud.dev](https://github.com/google/go-cloud) from 0.29.0 to
0.30.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/google/go-cloud/releases">gocloud.dev's
releases</a>.</em></p>
<blockquote>
<h2>v0.30.0</h2>
<p><strong>blob</strong></p>
<ul>
<li><strong>all</strong>: Add <code>Upload</code> and
<code>Download</code> methods that may be more efficient for some
drivers.</li>
<li><strong>s3blob</strong>: Add support for per-request
<code>s3v2.Options</code>.</li>
<li><strong>s3blob</strong>: Stop escaping second <code>/</code> in
<code>//</code>; it's no longer necessary.</li>
</ul>
<p><strong>pubsub</strong></p>
<ul>
<li><strong>gcppubsub</strong>: Make it possible to configure
<code>max_send_batch_size</code>.</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="d2d5bedb50"><code>d2d5bed</code></a>
all: prep for release (<a
href="https://redirect.github.com/google/go-cloud/issues/3263">#3263</a>)</li>
<li><a
href="c2e172b5a7"><code>c2e172b</code></a>
all: update dependencies (<a
href="https://redirect.github.com/google/go-cloud/issues/3262">#3262</a>)</li>
<li><a
href="098177a48c"><code>098177a</code></a>
blob/s3blob: fix the 'awssdk' argument examples</li>
<li><a
href="2e4fad43f0"><code>2e4fad4</code></a>
all: remove refs to deprecated xerrors</li>
<li><a
href="1db413f1b3"><code>1db413f</code></a>
pubsub/gcppubsub: make it possible to configure max_send_batch_size</li>
<li><a
href="0c8428bf43"><code>0c8428b</code></a>
blob: Add Upload and Download methods that may be more efficient for
some dri...</li>
<li><a
href="54c71241a5"><code>54c7124</code></a>
all: cleanup duplicate import statements</li>
<li><a
href="28b1328ae4"><code>28b1328</code></a>
all: minor code simplifications for returned boolean expressions</li>
<li><a
href="2a407f5e6a"><code>2a407f5</code></a>
blob/gcsblob: Refresh goldens</li>
<li><a
href="0cc16c8ae1"><code>0cc16c8</code></a>
all: update goldens (<a
href="https://redirect.github.com/google/go-cloud/issues/3252">#3252</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/google/go-cloud/compare/v0.29.0...v0.30.0">compare
view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=gocloud.dev&package-manager=go_modules&previous-version=0.29.0&new-version=0.30.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
using the new multiple files api to have a single commit/push for all
files of a package.
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Bumps
[cachix/install-nix-action](https://github.com/cachix/install-nix-action)
from 21 to 22.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/cachix/install-nix-action/releases">cachix/install-nix-action's
releases</a>.</em></p>
<blockquote>
<h2>install-nix-action-v22</h2>
<ul>
<li>Nix 2.16.1</li>
<li>Fix issues with System Integrity Protection when using macos-12</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="6ed004b9cc"><code>6ed004b</code></a>
Merge pull request <a
href="https://redirect.github.com/cachix/install-nix-action/issues/184">#184</a>
from cachix/macos-bump</li>
<li><a
href="e27879448e"><code>e278794</code></a>
Nix: 2.15.1 -> 2.16.1</li>
<li><a
href="8ab3881720"><code>8ab3881</code></a>
use system certs</li>
<li><a
href="16b951426e"><code>16b9514</code></a>
Merge pull request <a
href="https://redirect.github.com/cachix/install-nix-action/issues/182">#182</a>
from l0b0/feat/configure-editors</li>
<li><a
href="2c203fd87b"><code>2c203fd</code></a>
feat: Configure editors</li>
<li>See full diff in <a
href="https://github.com/cachix/install-nix-action/compare/v21...v22">compare
view</a></li>
</ul>
</details>
<br />
[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=cachix/install-nix-action&package-manager=github_actions&previous-version=21&new-version=22)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)
</details>
Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
this is needed when we run part of the pipeline on windows, and the rest
on linux, for example, the split build pro feature.
extracted from https://github.com/goreleaser/goreleaser/pull/3795
+ added tests for relative path thing
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>
Sigh, yet another regression from
4b78278292. I actually _did_ test already
with 10a627c196, but for some reason
failed to notice the error. Tested better now :/
This is a meta commit so this gets properly categorized in the
changelog.
Originally fixed in 265148c
Signed-off-by: Carlos Alexandro Becker <caarlos0@users.noreply.github.com>